Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo keyboard short #458

Closed
SylvainCorlay opened this issue Oct 8, 2024 · 7 comments · Fixed by #451
Closed

Redo keyboard short #458

SylvainCorlay opened this issue Oct 8, 2024 · 7 comments · Fixed by #451
Milestone

Comments

@SylvainCorlay
Copy link
Member

The redo keyboard shortcut should probably be consistent with that of the notebook editor and with the shortcut indicated in the "Edit" topbar menu, that is ⇧ ⌘ Z on OSX.

Image

@martinRenou
Copy link
Member

For the record, this is where the keybinding is defined https://github.com/jupytercad/JupyterCAD/blob/main/packages/base/src/keybindings.json#L9

@martinRenou martinRenou added this to the 3.0.0 milestone Oct 8, 2024
@arjxn-py
Copy link
Member

arjxn-py commented Oct 8, 2024

I shall look into how can i have different keybinding for OSX and Windows, Do you know already by any chance?

@SylvainCorlay
Copy link
Member Author

I think that we should be as close as possible to the notebook user experience for this.

@arjxn-py
Copy link
Member

arjxn-py commented Oct 8, 2024

I think that we should be as close as possible to the notebook user experience for this.

I agree, and will be On my way! to see how they're handling it upstream. And I believe it shall not be an issue anymore to have the same keybinding for redo both in normal notebook or jcad file as conflict issue shall resolve in #451

@arjxn-py
Copy link
Member

arjxn-py commented Oct 9, 2024

I couldn't find Ctrl Y or Accel Y for redo in jupyterlab's code, should I just update this to Accel Shift Z in that case?

@martinRenou
Copy link
Member

Indeed JupyterLab is never using Ctrl Y for redo, let's stay aligned with JupyterLab

@arjxn-py
Copy link
Member

I've done it along #451 in c560e8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants