Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add freecad icon #21

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Add freecad icon #21

merged 4 commits into from
Dec 2, 2024

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Nov 29, 2024 •
edited
Loading

Fix #14

Screenshot From 2024-11-29 15-53-57

@martinRenou martinRenou added the enhancement New feature or request label Nov 29, 2024
@SylvainCorlay
Copy link
Member

I think the highlighted icon should probably become white like other file icons.

@martinRenou
Copy link
Member Author

Actually I'm not sure I agree 😆

Screenshot From 2024-12-02 11-02-17

@martinRenou martinRenou closed this Dec 2, 2024
@martinRenou martinRenou reopened this Dec 2, 2024
@SylvainCorlay
Copy link
Member

SylvainCorlay commented Dec 2, 2024 •
edited
Loading

Actually I'm not sure I agree 😆

If the F-shaped central area takes the background color (selection blue) when highlighted, that could work.

@martinRenou
Copy link
Member Author

Screencast.From.2024-12-02.17-23-43.mp4

@martinRenou
Copy link
Member Author

It looks like the CI cannot be trusted anymore, I'll just merge

@martinRenou martinRenou merged commit c1e1329 into jupytercad:main Dec 2, 2024
6 of 7 checks passed
@martinRenou martinRenou deleted the icon branch December 2, 2024 16:32
@SylvainCorlay
Copy link
Member

It looks like the CI cannot be trusted anymore, I'll just merge

💯 we should never trust CI 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a launcher icon and use the FreeCAD logo for the file format
2 participants
@martinRenou @SylvainCorlay