Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FreeCAD compatible after guidata removal #12

Merged
merged 15 commits into from
Sep 27, 2024

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Sep 16, 2024

Follow up on jupytercad/JupyterCAD#413

fcad-color.mov

@arjxn-py
Copy link
Member Author

@martinRenou @trungleduc Should I remove _guidata_to_options & _options_to_guidata fully or is this enough?

Also wanted to confirm that if I shall bump JCAD dependencies from 2.0.0 to 3.0.0?

@martinRenou
Copy link
Member

Should I remove _guidata_to_options & _options_to_guidata fully or is this enough

I believe this is not enough. You should be able to test the colors loading when opening the file https://github.com/jupytercad/JupyterCAD-FreeCAD/blob/main/examples/ArchDetail.FCStd

Note that you need to install freecad micromamba install -c conda-forge freecad.

You need to adapt the _guidata_to_options and _options_to_guidata to read/write the colors from the FCSTD file and set the Color property you introduced in JupyterCad and the visible one.

@arjxn-py
Copy link
Member Author

Thanks @martinRenou, I'll be on it.

@arjxn-py
Copy link
Member Author

arjxn-py commented Sep 18, 2024

Hi, @martinRenou @trungleduc. Workflow requests approval. Plus I'm happy to have another interim look of yours :)
Thanks.

@arjxn-py
Copy link
Member Author

Sleepwalking 😴

@arjxn-py
Copy link
Member Author

jcad-fcad.mov

@arjxn-py arjxn-py changed the title Remove guidata support Make FreeCAD compatible after guidata removal Sep 23, 2024
jupytercad_freecad/freecad/loader.py Outdated Show resolved Hide resolved
jupytercad_freecad/freecad/loader.py Outdated Show resolved Hide resolved
@trungleduc
Copy link
Member

Thanks @arjxn-py

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@martinRenou martinRenou merged commit 2ff256f into jupytercad:main Sep 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants