Skip to content

Commit 4b0320d

Browse files
committed
Rename renderer_factory to renderer in python
1 parent 65b1fbf commit 4b0320d

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

python/ipyleaflet/ipyleaflet/leaflet.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1110,7 +1110,7 @@ class VectorTileLayer(Layer):
11101110
Opacity of the layer between 0. (fully transparent) and 1. (fully opaque).
11111111
visible: boolean, default True
11121112
Whether the layer is visible or not.
1113-
renderer_factory: string, default 'svg'
1113+
renderer: string, default 'svg'
11141114
Engine for rendering VectorTileLayers; either 'canvas' or 'svg'. Use 'svg' for interactive layers.
11151115
interactive: boolean, default False
11161116
Whether the layer is interactive or not.
@@ -1132,7 +1132,7 @@ class VectorTileLayer(Layer):
11321132
max_zoom = Int(18).tag(sync=True, o=True)
11331133
min_native_zoom = Int(default_value=None, allow_none=True).tag(sync=True, o=True)
11341134
max_native_zoom = Int(default_value=None, allow_none=True).tag(sync=True, o=True)
1135-
renderer_factory = Unicode('svg').tag(sync=True, o=True)
1135+
renderer = Unicode('svg').tag(sync=True, o=True)
11361136
get_feature_id = Unicode(allow_none=True, default_value=None).tag(sync=True, o=True)
11371137
feature_style = Dict().tag(sync=True)
11381138

python/jupyter_leaflet/src/layers/VectorTileLayer.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class LeafletVectorTileLayerModel extends LeafletLayerModel {
2020
interactive: false,
2121
visible: true,
2222
opacity: 1.0,
23-
renderer_factory: 'svg',
23+
rendererFactory: L.svg.tile,
2424
get_feature_id: null,
2525
};
2626
}
@@ -41,12 +41,13 @@ export class LeafletVectorTileLayerView extends LeafletLayerView {
4141
};
4242
}
4343

44-
let r: any = options['rendererFactory'];
45-
46-
if (r === 'canvas') {
47-
options['rendererFactory'] = L.canvas.tile;
48-
} else {
49-
options['rendererFactory'] = L.svg.tile;
44+
if ('renderer' in options) {
45+
let r: any = options['renderer'];
46+
if (r === 'canvas') {
47+
options['rendererFactory'] = L.canvas.tile;
48+
} else {
49+
options['rendererFactory'] = L.svg.tile;
50+
}
5051
}
5152

5253
if ('layerStyles' in options) {

0 commit comments

Comments
 (0)