We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompted by comment in #1478 (comment)
in general you never want to pass anything but a literal string as a first argument go the various log.info|warn|error methods; see https://docs.astral.sh/ruff/rules/#flake8-logging-format-g
log.info
warn
error
That is to say, no f-strings; not even pre-formatted variables, as it prevents formatters to do a lot of what they are supposed to do.
There is at least 2 dozen usage of this pattern in the codebase:
$ grep -r 'log.info(f' . | wc -l 26
The text was updated successfully, but these errors were encountered:
Is this a duplicate of #1186?
Sorry, something went wrong.
It is indeed.
No branches or pull requests
Prompted by comment in #1478 (comment)
in general you never want to pass anything but a literal string as a first argument go the various
log.info
|warn
|error
methods; see https://docs.astral.sh/ruff/rules/#flake8-logging-format-gThat is to say, no f-strings; not even pre-formatted variables, as it prevents formatters to do a lot of what they are supposed to do.
There is at least 2 dozen usage of this pattern in the codebase:
The text was updated successfully, but these errors were encountered: