Favicon for mystjs should use the MyST logo #58
Comments
|
Totally agree! It is something we have been putting off for a bit as we need to dynamically serve the favicon. Thanks for the report, pushes it higher on my priority list. :) |
|
Quick update on this, we are ripping out the theme in the next two weeks (current plan here) and this should be addressed in that chunk of work! |
* Update mystjs. Add more definitive return type * Add linkBlock transformation and title/desc/thumb to link cache Co-authored-by: Yuxi Wang <[email protected]>
|
This has been updated, with a slightly better theme for the https://myst.tools site. There is still lots of work to do to make this theme easier to customize, currently we are developing this theme here: https://github.com/curvenote/myst-tools-theme/blob/main/src/public/favicon.ico There are a lot of cleanups and generalizations still to do on this front, but I am going to close this specific issue for now! |
@rowanc1 The new deployed theme on https://www.myst.tools looks great. I have just tried to apply the |
|
Hm, not sure, it should build:css in the sub package (src). Maybe a platform or windows thing? You could try executing that script specifically (build:css), it uses tailwind. |
|
ran build and build:css in the theme/theme (after replacing the existing ones with the myst-tools-theme source code), but still same result. I guess a configuration is welcome to allow the definition of the theme. Is this what you were thinking at? |
Describe the bug
The favicon for js.myst.tools uses the curvenote logo. Instead it should use the myst logo!
Reproduce the bug
List your environment
No response
The text was updated successfully, but these errors were encountered: