Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more robust index sampling #79

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Implement more robust index sampling #79

wants to merge 21 commits into from

Conversation

juntyr
Copy link
Owner

@juntyr juntyr commented Nov 13, 2021 •
edited
Loading

Switches from f64 based to binary rejection-sampling based index sampling.

Fixes #127

  • Add test suite for necsim/core/cogs/rng
  • Fix necsim/impls/no-std/cogs/active-lineage-sampler/alias tests
  • Split distribution samplers into components
  • Add correct sampler components for [0,1), (0,1], Bernoulli, Index
  • Add widening sampler components for Index
  • Reuse components between Simple, Cuda, and Rand
  • Simplify trait bounds - is exposing which components a supercomponent/an algorithm is based on better and more stable than exposing which distributions we need to be able to sample
  • Simplify necsim cog trait bounds in general
  • Switch algorithms to explicit Rngs
  • Test
  • Review

@juntyr juntyr self-assigned this Nov 13, 2021
@github-actions github-actions bot force-pushed the rng-sample-index branch 4 times, most recently from 8f74799 to 33c9672 Compare November 16, 2021 08:16
@github-actions github-actions bot force-pushed the rng-sample-index branch 6 times, most recently from 8512aab to e4ca402 Compare November 23, 2021 05:45
@github-actions github-actions bot force-pushed the rng-sample-index branch 4 times, most recently from aed4f27 to 114b410 Compare November 30, 2021 09:20
@github-actions github-actions bot force-pushed the rng-sample-index branch 5 times, most recently from 48d1320 to 3ca1d15 Compare December 9, 2021 06:09
@github-actions github-actions bot force-pushed the rng-sample-index branch 5 times, most recently from 940660a to fcd8e45 Compare December 17, 2021 17:20
@github-actions github-actions bot force-pushed the rng-sample-index branch 2 times, most recently from f88aaa6 to cbb807d Compare December 27, 2021 20:01
@github-actions github-actions bot force-pushed the rng-sample-index branch 2 times, most recently from 0e0513f to b71924c Compare January 3, 2022 09:43
juntyr and others added 13 commits October 26, 2023 18:24
@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

9 similar comments
@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2024

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@juntyr juntyr mentioned this pull request May 20, 2024
Merged
@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

4 similar comments
@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@github-actions GitHub Actions
Copy link

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Rebase of head ref rng-sample-index on base ref main failed. Conflicts must be resolved manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@juntyr juntyr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split off RNG distribution sampling into separate cog
2 participants
@juntyr @codecov-commenter