Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening addresses from contacts app, URL style encoding characters are not translated. #203

Open
Magicrafter13 opened this issue Oct 23, 2024 · 3 comments
Labels
Fixed in next Release This issue is allready fixed, but the next release is not out yet

Comments

@Magicrafter13
Copy link

I don't know why this is the case, but when I tap an address in the Samsung Contacts app, I get the choice of opening in Google Maps or PocketMaps. When opening in PocketMaps, it would seem that Samsung Contacts sends over the address using URL encoding (see pictures).

Now, this could be a bug in Samsung's app, however (1) we know we can't get that fixed easily, and (2) Google Maps handles this fine so I am inclined to assume this is "normal", though I still feel gross saying that...

Anyway, to avoid issues, I used the Whitehouse address in my example screenshots below.

What was received from the contacts app:
Screenshot_20241022_213312_PocketMaps
Search button toast:
Screenshot_20241022_213322_PocketMaps
Manually corrected address text:
Screenshot_20241022_213441_PocketMaps

(And yes, I did input the address slightly wrong in my contacts, but the search still worked after I replaced the encoded characters.)

I don't know if all contacts apps do this, and thus this can be a blanket fix, or if it needs to be dynamically detected? I feel like it would be safe either way because I can't imagine a percent sign being in a valid address.

@Starcommander
Copy link
Collaborator

Thanks for creating this issue.
Seems, it is using URL escape codes for white spaces.
https://docs.microfocus.com/OMi/10.62/Content/OMi/ExtGuide/ExtApps/URL_encoding.htm
Should be easy to fix.
I will take a look, when I have the time.

@Starcommander
Copy link
Collaborator

The issue is reproducible on locations of contacts.
But locations from Calendar are working correctly.

@Starcommander
Copy link
Collaborator

Starcommander commented Oct 31, 2024

Should be fixed in next version. (tested and works)

@Starcommander Starcommander added the Fixed in next Release This issue is allready fixed, but the next release is not out yet label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in next Release This issue is allready fixed, but the next release is not out yet
Projects
None yet
Development

No branches or pull requests

2 participants