Get rewrite up and running #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @trulsf, I've sent you an invite to become a maintainer. This should let you push to the I had no plans for the rewrite other than it should happen 😄 |
|
Since this is only v0.4.3, you have permission to make any changes you deem fit. We can do a series of smaller PRs if that's easier. There is no rush to tag v0.5.0 |
odow
reviewed
Jan 8, 2025
|
Does the README need updating? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some time to look a bit closer at
PiecewiseLinearOpt. Both to get better acquainted with the code and to see how easy it is to combine it with functionality ofPiecewiseAffineApprox, I have had a look at the work Joey had started back in 2020 in the rewrite branch. As part of this I have done some minor updates and changes to have this up and running with the latest JuMP and using HiGHS for testing. I have also added an interface that matches what exists in the current version to run all tests.I got most methods working (except
MultipleChoicethat will need some conversion routines from a vertex-representation to halfplane-representation andOptimalIndependentBranchingthat was just too slow).@odow When you mention a complete rewrite in issue #54, did you consider using this branch as a starting point? It uses more dispatching and avoids the giant
if-switch you mention. It also opens up for more flexibility in algorithms and number of variables (both input and output).