Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caret affects test identity #119

Open
eddyashton opened this issue Oct 5, 2021 · 1 comment
Open

Caret affects test identity #119

eddyashton opened this issue Oct 5, 2021 · 1 comment

Comments

@eddyashton
Copy link

If I have a metric called "Foo" that should have been called "Foo^" (because I realised after running it for a while that it was showing increases as RED, and I want them GREEN), then ideally it would continue to use my old numbers and just redraw the graph with the correct colours. However, it currently views this as a new metric, so draws it on a blank graph.

@achamayou
Copy link
Collaborator

If we go down this route, I suggest we get rid of the "^" hack altogether, and pass an explicit direction= attribute instead.

The only reason this was done with "^" and hiding it at display time was expediency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants