Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Is this library secure? #73

Open
Borwe opened this issue Oct 14, 2021 · 3 comments
Open

[Security] Is this library secure? #73

Borwe opened this issue Oct 14, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@Borwe
Copy link

Borwe commented Oct 14, 2021

From what I can see, it requires the user inputting their callbacks, Passkeys, and even Business shortcodes.
This info cannot surely be mangled by anything whether proguard, or R8 or yGuard, which I presume some users
will even put the variables holding this info in static final Strings 🤣 making it easier for attackers.

If someone is to de-compile an app using this library what security is put into place to avoid leaking out the data stated on top.

EG:
A hacker decompiles, and just greps output for "https://" to get callback urls, and then begins sending dummy requests to it,
now if the user of this library has it that that callback is used to validate a purchase, a hacker can do unlimited purchases without paying a single coin.

This is just an example, I assume there are many more attack vectors.

Maybe users of the library can be adviced to not store those variables directly in their app but pull them from some REST Api in an encrypted format, decrypt on the device and use it?

@e-kibet
Copy link

e-kibet commented Apr 19, 2022

I total agree with the above info.

I would suggest we have the .properties file in which the library will be reading the credentials needed and therefore would provided another level of security.
Alternately we can also have a api-key as third set of security for a library

@jumaallan
Copy link
Owner

Thank you for the feedback. Will circle back on this

@jumaallan jumaallan added the enhancement New feature or request label Jun 20, 2022
@langsmith
Copy link

Any update or progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants