Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses BlockedStatus instead of ErrorStatus #62

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Uses BlockedStatus instead of ErrorStatus #62

merged 1 commit into from
Feb 7, 2024

Conversation

manadart
Copy link
Member

@manadart manadart commented Feb 7, 2024

With the new version of Ops, setting ErrorStatus explicitly causes an error to be thrown.

Here we use BlockedStatus instead when we can't determine the API port from agent configuration.

@manadart
Uses BlockedStatus instead of ErrorStatus, which when set explicitly
6cd096b 
results in an error with the new version of Ops.
cderici
cderici approved these changes Feb 7, 2024
View reviewed changes
Copy link

@cderici cderici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it makes sense to me 👍

@manadart manadart merged commit 470f7c5 into 3.3 Feb 7, 2024
7 of 8 checks passed
@manadart manadart mentioned this pull request Feb 7, 2024
Merged
@manadart manadart deleted the 3.3-fix-status branch February 10, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cderici cderici cderici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manadart @cderici