Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Balancer Logo #222

Open
Ak-wa opened this issue May 13, 2024 · 2 comments
Open

Custom Balancer Logo #222

Ak-wa opened this issue May 13, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Ak-wa
Copy link

Ak-wa commented May 13, 2024

Hi, im trying to change the MultiJuicer Logo at initial "Getting Started" page where users can create a team.

The logo & favicon I added in values.yaml works - but only on the authenticated shop page, not at the landing page for creating a team.

multijuice_issue

Im launching Multijuicer via the following command
helm install -f values.yaml multi-juicer ./multi-juicer/helm/multi-juicer/

with content of values.yaml:

...
config: |
    application:
      logo: https://url-to-my-logo.svg
      favicon: https://url-to-my-favicon.ico


      showVersionNumber: false
...

How do i make the Multijuicer Balancer use my own logo?

@J12934
Copy link
Member

J12934 commented May 13, 2024

Hi @Ak-wa

that's currently not supported to be modified. Only the juice shop logos are customizable.

I'd be happy to review & merge pull requests which make it customizable :)

@J12934 J12934 added the enhancement New feature or request label May 13, 2024
@stuebingerb
Copy link
Contributor

Just an implementation note: the height of the logo is currently hardcoded and increasing it impacts the rest of the layout. It might make sense to aim for a custom page template, not just the logo src.
That way we could also support custom notifications, e.g. an "award ceremony @12pm room 3" banner on the score-board 🙂

@J12934 J12934 added the help wanted Extra attention is needed label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants