why is push disabled on your dockerbuild?

[KyleSanderson]

Describe the bug

camply/.github/workflows/docker.yaml

Line 45 in b110eea

push: false

[juftin]

There are two docker image build jobs in CI/CD. The one that you linked is a job titled docker-ci-test which is simply a test that ensures the image can built:

camply/.github/workflows/docker.yaml

Line 45 in b110eea

push: false

The second job is titled docker-hub-publish and is located in the publish.yaml workflow. This where the artifact is pushed after a release is generated:

camply/.github/workflows/publish.yaml

Lines 72 to 77 in 6a00c1b

	- name: Docker Image Building and Publishing
	id: docker_build
	uses: docker/build-push-action@v5
	with:
	push: true
	tags: juftin/${{ env.PACKAGE_NAME }}:latest,juftin/${{ env.PACKAGE_NAME }}:${{ env.PACKAGE_VERSION }}

[KyleSanderson]

The second job is titled docker-hub-publish and is located in the publish.yaml workflow. This where the artifact is pushed after a release is generated:

camply/.github/workflows/publish.yaml

Lines 72 to 77 in 6a00c1b

	- name: Docker Image Building and Publishing
	id: docker_build
	uses: docker/build-push-action@v5
	with:
	push: true
	tags: juftin/${{ env.PACKAGE_NAME }}:latest,juftin/${{ env.PACKAGE_NAME }}:${{ env.PACKAGE_VERSION }}

Ah! You're still using Docker Hub! Would it be possible to also push to GitHub Packages? I was looking for one, didn't find one, and ended up making my own. Would much rather prefer to stay on the upstream image.

[juftin]

Yep, publishing to Docker Hub is part of the release process: https://hub.docker.com/r/juftin/camply

I'd consider using the GitHub Docker Container Registry, but would probably prefer just to use a single registry. Any reason why you prefer to pull an image from GitHub instead of Docker Hub?

[KyleSanderson]

I just didn't see it on the RHS (packages) and there was no mention of docker in the readme.md