New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readUntil calculation #16

Open

cfwcode opened this issue Mar 8, 2022 · 0 comments

cfwcode commented Mar 8, 2022

After reading the code and ID3v2.3 spec, I think it is a bug when calculate readUntil in class ID3v2Tag, line 420.

readUntil = _id3v2Header.TagSize - _id3v2ExtendedHeader.SizeIncludingSizeBytes - frameIDSize;

it minus _id3v2ExtendedHeader.SizeIncludingSizeBytes when there is no extended header,
frame id is read in the followed read() method method, don't need to minus its size here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment