From ff6a560ff6479f0eba8c2907bec60383bcaed2de Mon Sep 17 00:00:00 2001 From: Adam McCrea Date: Thu, 25 Jan 2024 14:45:28 -0500 Subject: [PATCH] Fix: Don't include "enabled" metadata with adapters (#193) This data can change depending on whether the reporter process is running on a "redundant instance", so it's misleading to report it as metadata. --- judoscale-ruby/lib/judoscale-ruby.rb | 11 +---------- judoscale-ruby/lib/judoscale/reporter.rb | 4 +--- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/judoscale-ruby/lib/judoscale-ruby.rb b/judoscale-ruby/lib/judoscale-ruby.rb index 4eaf7c16..223ed9dc 100644 --- a/judoscale-ruby/lib/judoscale-ruby.rb +++ b/judoscale-ruby/lib/judoscale-ruby.rb @@ -21,17 +21,8 @@ class << self end class Adapter < Struct.new(:identifier, :adapter_info, :metrics_collector) - attr_accessor :enabled - - def initialize(identifier, adapter_info, metrics_collector) - super - self.enabled = false - end - def as_json - { - identifier => adapter_info.merge(enabled: enabled) - } + {identifier => adapter_info} end end diff --git a/judoscale-ruby/lib/judoscale/reporter.rb b/judoscale-ruby/lib/judoscale/reporter.rb index ab4d1c81..0bc563db 100644 --- a/judoscale-ruby/lib/judoscale/reporter.rb +++ b/judoscale-ruby/lib/judoscale/reporter.rb @@ -25,9 +25,7 @@ def start!(config, adapters) end enabled_adapters, skipped_adapters = adapters.partition { |adapter| - if adapter.metrics_collector&.collect?(config) - adapter.enabled = true - end + adapter.metrics_collector&.collect?(config) } metrics_collectors_classes = enabled_adapters.map(&:metrics_collector) adapters_msg = enabled_adapters.map(&:identifier).concat(