From 0c8d96a84dffcc31ee91f2e483073fd79363bbe9 Mon Sep 17 00:00:00 2001 From: Wynn Netherland Date: Thu, 14 Nov 2013 09:37:39 -0600 Subject: [PATCH] Use the stack for .root because it's not a :snowflake: --- lib/octokit/client.rb | 2 +- spec/octokit/client_spec.rb | 11 ++++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/lib/octokit/client.rb b/lib/octokit/client.rb index 2d7b98d08..9b172ad6c 100644 --- a/lib/octokit/client.rb +++ b/lib/octokit/client.rb @@ -217,7 +217,7 @@ def agent # # @return [Sawyer::Resource] def root - agent.start.data + get "/" end # Response for last HTTP request diff --git a/spec/octokit/client_spec.rb b/spec/octokit/client_spec.rb index f8a92ec30..e203b450a 100644 --- a/spec/octokit/client_spec.rb +++ b/spec/octokit/client_spec.rb @@ -223,7 +223,7 @@ assert_requested :get, github_url('/user') end end - describe "when application authenticated", :vcr do + describe "when application authenticated" do it "makes authenticated calls" do client = Octokit.client client.client_id = '97b4937b385eb63d1f46' @@ -257,6 +257,15 @@ expect(root.rels[:issues].href).to eq "https://api.github.com/issues" end end + + it "passes app creds in the query string" do + root_request = stub_get("/?client_id=97b4937b385eb63d1f46&client_secret=d255197b4937b385eb63d1f4677e3ffee61fbaea") + client = Octokit.client + client.client_id = '97b4937b385eb63d1f46' + client.client_secret = 'd255197b4937b385eb63d1f4677e3ffee61fbaea' + client.root + assert_requested root_request + end end describe ".last_response", :vcr do