Merge branch 'master' into type-fix-support-2

.eslintignore

@@ -1 +1 @@
-coverage
+coverage/

.eslintrc

@@ -14,30 +14,41 @@
       "sourceType": "script",
     },
     "rules": {
-        "comma-dangle": [2, "never"],
-        "object-curly-spacing": [2, "never"],
-        "object-shorthand": [2, "always"],
-        "array-bracket-spacing": [2, "never"],
+        "comma-dangle": [2, "always-multiline"],
+        "object-shorthand": [2, "always", {
+          "ignoreConstructors": false,
+          "avoidQuotes": false, // this is the override vs airbnb
+        }],
         "max-len": [2, 120, {
           "ignoreStrings": true,
           "ignoreTemplateLiterals": true,
           "ignoreComments": true,
         }],
-        "operator-linebreak": [2, "after"],
         "consistent-return": 0,
 
         "prefer-destructuring": [2, { "array": false, "object": false }, { "enforceForRenamedProperties": false }],
-
+        "prefer-object-spread": 0, // until node 8 is required
+        "prefer-rest-params": 0, // until node 6 is required
+        "prefer-spread": 0, // until node 6 is required
+        "function-call-argument-newline": 1, // TODO: enable
         "function-paren-newline": 0,
         "no-plusplus": 1,
         "no-param-reassign": 1,
-        "no-mixed-operators": 1,
-        "no-restricted-syntax": 1,
+        "no-unreachable-loop": 1, // TODO: enable
+        "no-restricted-syntax": [2, {
+            "selector": "ObjectPattern",
+            "message": "Object destructuring is not compatible with Node v4"
+        }],
+        "strict": [2, "safe"],
         "valid-jsdoc": [2, {
           "requireReturn": false,
           "requireParamDescription": false,
           "requireReturnDescription": false,
         }],
+
+        "eslint-plugin/consistent-output": 0,
+        "eslint-plugin/require-meta-schema": 0,
+        "eslint-plugin/require-meta-type": 0
     },
     "overrides": [
       {
@@ -46,5 +57,11 @@
           "no-template-curly-in-string": 1,
         },
       },
+      {
+        "files": "markdown.config.js",
+        "rules": {
+          "no-console": 0,
+        },
+      },
     ],
 }

.github/workflows/node-4+.yml

@@ -0,0 +1,117 @@
+name: 'Tests: node.js'
+
+on: [pull_request, push]
+
+jobs:
+  matrix:
+    runs-on: ubuntu-latest
+    outputs:
+      latest: ${{ steps.set-matrix.outputs.requireds }}
+      minors: ${{ steps.set-matrix.outputs.optionals }}
+    steps:
+      - uses: ljharb/actions/node/matrix@main
+        id: set-matrix
+        with:
+          versionsAsRoot: true
+          type: majors
+          preset: '>=4'
+
+  latest:
+    needs: [matrix]
+    name: 'latest majors'
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: ${{ fromJson(needs.matrix.outputs.latest) }}
+        eslint:
+          - 8
+          - 7
+          - 6
+          - 5
+          - 4
+          - 4.14 # last version without messageId
+          - 3
+        babel-eslint:
+          - 10
+          - 9
+          - 8
+        exclude:
+          - node-version: 5
+            babel-eslint: 10
+          - node-version: 5
+            babel-eslint: 9
+          - node-version: 4
+            babel-eslint: 10
+          - node-version: 4
+            babel-eslint: 9
+          - node-version: 15
+            eslint: 8
+          - node-version: 13
+            eslint: 8
+          - node-version: 11
+            eslint: 8
+          - node-version: 11
+            eslint: 7
+          - node-version: 10
+            eslint: 8
+          - node-version: 9
+            eslint: 8
+          - node-version: 9
+            eslint: 7
+          - node-version: 8
+            eslint: 8
+          - node-version: 8
+            eslint: 7
+          - node-version: 7
+            eslint: 8
+          - node-version: 7
+            eslint: 7
+          - node-version: 7
+            eslint: 6
+          - node-version: 6
+            eslint: 8
+          - node-version: 6
+            eslint: 7
+          - node-version: 6
+            eslint: 6
+          - node-version: 5
+            eslint: 8
+          - node-version: 5
+            eslint: 7
+          - node-version: 5
+            eslint: 6
+          - node-version: 5
+            eslint: 5
+          - node-version: 4
+            eslint: 8
+          - node-version: 4
+            eslint: 7
+          - node-version: 4
+            eslint: 6
+          - node-version: 4
+            eslint: 5
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install ${{ matrix.node-version }} && npm install'
+        with:
+          node-version: ${{ matrix.node-version }}
+          after_install: |
+            npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.node-version >= 14 && '5' || (matrix.node-version >= 12 && '4' || (matrix.node-version >= 10 && '4.0' || (matrix.node-version >= 8 && '3' || '2'))) }}" "babel-eslint@${{ matrix.babel-eslint }}"
+          skip-ls-check: ${{ matrix.node-version < 10 && true || false }}
+        env:
+          NPM_CONFIG_LEGACY_PEER_DEPS: true
+      - run: npx ls-engines
+        if: ${{ matrix.node-version >= 12 }}
+      - run: npm run unit-test
+      - uses: codecov/codecov-action@v1
+
+  node:
+    name: 'node 4+'
+    needs: [latest]
+    runs-on: ubuntu-latest
+    steps:
+      - run: 'echo tests completed'

.github/workflows/node-pretest.yml

@@ -0,0 +1,32 @@
+name: 'Tests: pretest/posttest'
+
+on: [pull_request, push]
+
+jobs:
+  pretest:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install lts/* && npm install'
+        with:
+          node-version: 'lts/*'
+        env:
+          NPM_CONFIG_LEGACY_PEER_DEPS: true
+      - run: npm run pretest
+
+  posttest:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install lts/* && npm install'
+        with:
+          node-version: 'lts/*'
+        env:
+          NPM_CONFIG_LEGACY_PEER_DEPS: true
+      - run: npx ls-engines
+      - run: echo 'legacy-peer-deps=true' >> .npmrc
+      - run: npm run posttest

.github/workflows/readme.yml

@@ -0,0 +1,17 @@
+name: 'Tests: readme'
+
+on: [pull_request, push]
+
+jobs:
+  readme:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install lts/* && npm install'
+        with:
+          node-version: 'lts/*'
+        env:
+          NPM_CONFIG_LEGACY_PEER_DEPS: true
+      - run: npm run generate-list-of-rules:check

.github/workflows/rebase.yml

@@ -0,0 +1,15 @@
+name: Automatic Rebase
+
+on: [pull_request_target]
+
+jobs:
+  _:
+    name: "Automatic Rebase"
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ljharb/rebase@master
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/require-allow-edits.yml

@@ -0,0 +1,12 @@
+name: Require “Allow Edits”
+
+on: [pull_request_target]
+
+jobs:
+  _:
+    name: "Require “Allow Edits”"
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: ljharb/require-allow-edits@main

.github/workflows/smoke-test.yml

@@ -0,0 +1,25 @@
+name: Smoke test
+
+on:
+  schedule:
+    - cron: '0 0 * * SUN'
+  workflow_dispatch:
+
+jobs:
+  smoke-test:
+    if: ${{ github.repository == 'yannickcr/eslint-plugin-react' || github.event_name == 'workflow_dispatch' }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ljharb/actions/node/install@main
+        name: 'nvm install lts/* && npm install'
+        with:
+          node-version: 'lts/*'
+          skip-ls-check: true
+      - run: |
+          npm link
+          npm link eslint-plugin-react
+      - uses: AriPerkkio/eslint-remote-tester-run-action@v2
+        with:
+          issue-title: 'Results of weekly scheduled smoke test'
+          eslint-remote-tester-config: test/eslint-remote-tester.config.js

.gitignore

@@ -19,6 +19,7 @@ node_modules
 !tests/**/node_modules
 npm-debug.log
 sftp-config.json
+eslint-remote-tester-results
 
 # Only apps should have lockfiles
 yarn.lock