Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/usability enhancements #10

Open
5 of 10 tasks
omgmog opened this issue Feb 10, 2021 · 1 comment
Open
5 of 10 tasks

Style/usability enhancements #10

omgmog opened this issue Feb 10, 2021 · 1 comment

Comments

@omgmog
Copy link
Member

omgmog commented Feb 10, 2021

This is more for the sake of keeping track of some issues I've noticed, before I or others get a chance to resolve them.

  • Footer not present across all pages (Fixed in Footer on all pages #18)
  • Footer balancing (visual)
  • Link hover/active/visited styles
  • Text/background contrast
  • target="_blank" on external links (and perhaps rel="nofollow" 🤷)
  • Check cross-device/browser, the vmax/vmin/vh/vw units might not behave as expected everywhere...
  • Remove even more of the boilerplate styles from the base template. AFAIK we're not using any of the .tdbc-* stuff now?
  • The language around past/future events might be a bit clunky when the event is occurring Expanded below.
  • The og:image twitter:image meta tags have incorrect values
  • The /feed/ isn't populated

Feel free to add anything else and create a PR for any fixes 💯

@omgmog
Copy link
Member Author

omgmog commented Feb 10, 2021

Regarding language around future/occurring/past events

Future:

  • event has date, before the event this is in the future

Occurring:

  • event has date, when the event is happening this is in the past

Past:

  • event has date, this is in the past
  • event has happened: true flag too

This would also need some changes to the occured filter (also that's a typo!) to cater to all 3 cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant