Skip to content
This repository has been archived by the owner on Jun 4, 2020. It is now read-only.

Serving Assets? #32

Open
mudassir0909 opened this issue Jun 20, 2016 · 4 comments
Open

Serving Assets? #32

mudassir0909 opened this issue Jun 20, 2016 · 4 comments

Comments

@mudassir0909
Copy link
Member

mudassir0909 commented Jun 20, 2016

What's the best way to serve assets for your theme? Right now I'm using custom font built using icomoon for theme icons, since the icon font file can't be served, I'm converting the font to base64 format & inlining it.

Can we serve any theme related assets? Perhaps a folder where the theme owners can put theme related assets & it can be served

@thomasdavis
Copy link
Member

A public folder sounds good.

Because the themes are pushed to npm, you could also use npmcdn.com in your code to retrieve those files?

@mudassir0909
Copy link
Member Author

this is awesome :)

Didn't know about npmcdn.com, we can go for it instead of serving via a public folder

@thomasdavis
Copy link
Member

Yeah rad, I imagine we could have a resource lib later that knows how to infer the full npmcdn path by itself when in production because it would always be the same.

npmcdn.com + package.name + /public/ + resource.jpg

@mudassir0909
Copy link
Member Author

yes, sounds good, we could have a handlebars helper which points to local folder during development & npmcdn during production

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants