Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: More dark mode problems - pro-help #1289

Open
gregsdennis opened this issue Jan 10, 2025 · 5 comments · May be fixed by #1352
Open

🐛 Bug: More dark mode problems - pro-help #1289

gregsdennis opened this issue Jan 10, 2025 · 5 comments · May be fixed by #1352
Assignees
@jagpreetrahi
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Available No one has claimed responsibility for resolving this issue.

Comments

@gregsdennis
Copy link
Member

Describe the bug

Discovered more dark mode issues.

Steps To Reproduce

https://json-schema.org/pro-help

  • LinkedIn and Github icons should be white
  • TSC label text should be dark
  • "Reach out" button is difficult to see and read

Expected Behavior

See above

Screenshots

image

Device Information [optional]

- OS: Windows
- Browser: Firefox

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No
@gregsdennis gregsdennis added 🐛 Bug Indicates that the issue is a bug or defect. Status: Triage This is the initial status for an issue that requires triage. labels Jan 10, 2025
@DhairyaMajmudar
Copy link
Member

Thank you Greg for the issue

@DhairyaMajmudar DhairyaMajmudar added Status: Available No one has claimed responsibility for resolving this issue. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: Triage This is the initial status for an issue that requires triage. labels Jan 10, 2025
@shantanu2107
Copy link
Contributor

Hi @DhairyaMajmudar, can you assign this issue to me?

@cbum-dev
Copy link
Contributor

cbum-dev commented Jan 11, 2025 •
edited
Loading

Hey @DhairyaMajmudar @gregsdennis I have fixed this issue, can you please assign this to me, so that I can raise a PR.

@AQIB-NAWAB
Copy link

@DhairyaMajmudar can i work on this issue ??

@Thund3rHawk Thund3rHawk mentioned this issue Jan 12, 2025
Closed
@jagpreetrahi
Copy link

Hey @DhairyaMajmudar , I hope you are doing well , I'd love to work on this issue , can I work on this if you assign me.

@jagpreetrahi jagpreetrahi linked a pull request Jan 21, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetrahi jagpreetrahi

Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Available No one has claimed responsibility for resolving this issue.
Projects
Website Contributor Board
Status: No status
Milestone
No milestone
6 participants
@gregsdennis @shantanu2107 @cbum-dev @AQIB-NAWAB @DhairyaMajmudar @jagpreetrahi