Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid JSON reported invalid #34

Open
notEthan opened this issue Jul 25, 2024 · 4 comments
Open

Valid JSON reported invalid #34

notEthan opened this issue Jul 25, 2024 · 4 comments

Comments

@notEthan
Copy link

I get "Error: Error processing schema: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data" for valid JSON, even as simple as {}.

Seems to be when a $schema key is absent? Even though it doesn't look like the tool uses the $schema value.

@notEthan notEthan changed the title Valid JSON reported Valid JSON reported invalid Jul 25, 2024
@suprith-hub
Copy link
Collaborator

@notEthan that was because jsonschema framing uses $schema that works now, maybe release again with all the tests working. Soon!

@jeremyfiel
Copy link

same as of today

@suprith-hub
Copy link
Collaborator

Hm... 😅, a slight mistake here and there while deploying, now I'll redeploy again and use schema myself if user doesnt provide, instead of throwing error:
Any suggestions on this @jeremyfiel ..?

@jeremyfiel
Copy link

for a transformation tool, i don't think you can use a default $schema value because depending on the schema you choose, it can output different transformations. I would require the user to use one or at the very least, require them to select from the dropdown.

you have to be careful with the earlier drafts, as they didn't have $schema defined at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants