We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi team, look at this method
JsonPath/json-path/src/main/java/com/jayway/jsonpath/Configuration.java
Line 70 in 2d4cc06
Its function name is to add evaluationListener, but actually set it's evaluationListener collection.
And there is already an setEvaluationListeners method here.
may addEvaluationListeners should be change to
public Configuration addEvaluationListeners(EvaluationListener... evaluationListener){ Set<EvaluationListener> listenerSet = new HashSet<EvaluationListener>(); listenerSet.addAll(this.evaluationListeners); listenerSet.addAll(asList(evaluationListener)); return Configuration.builder().jsonProvider(jsonProvider).mappingProvider(mappingProvider).options(options).evaluationListener(listenerSet).build(); }
This modification seems to better match the function name as well as the code design
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi team,
look at this method
JsonPath/json-path/src/main/java/com/jayway/jsonpath/Configuration.java
Line 70 in 2d4cc06
Its function name is to add evaluationListener, but actually set it's evaluationListener collection.
And there is already an setEvaluationListeners method here.
may addEvaluationListeners should be change to
This modification seems to better match the function name as well as the code design
The text was updated successfully, but these errors were encountered: