Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hints & PEP 561 packaging #146

Open
tuukkamustonen opened this issue May 7, 2021 · 2 comments · May be fixed by #184
Open

Type hints & PEP 561 packaging #146

tuukkamustonen opened this issue May 7, 2021 · 2 comments · May be fixed by #184
Labels
help-wanted open to a pull request to address this issue
Milestone
4.1

Comments

@tuukkamustonen
Copy link

tuukkamustonen commented May 7, 2021 •
edited
Loading

Add type hints to all (public API) code make the distribution PEP 561 compliant. This allows mypy (and other tools?) to find the type hints and use them in linting.

In practice, add py.typed file to statsd package, and include it in the package:

setup(
    package_data={'statsd': ['py.typed']},
    zip_safe=False,  # not needed with wheels, AFAIK
)

PEP 561: https://www.python.org/dev/peps/pep-0561/
@orsinium
Copy link

orsinium commented Nov 1, 2021

I want to give it a try but with dropping support for Python 2.7. Writing all type annotations as stubs or comments is a bit painful and hard to maintain.

This was referenced Nov 2, 2021
Closed
Closed
csestelo pushed a commit to Destygo/pystatsd that referenced this issue Jul 18, 2022
@Wellan89
Implement the variable validation logic in the user input node (jsoco…
d9d6a7a 
…l#146)

* Implemented get_variable_type on the repository

* Fetching variable type in the user input node execution

* Added test to check for email validation

* Validating email addresses

* Raise an error if the reprompt is not needed but not defined

* Show the cancel quick reply

* Renaming the agent handover failure quick replies logic into a more generic name

* Add Cancel QR texts in all languages

* Do not show the cancel quick reply if the targeted use case is not published

* Upgrade requirements
@jsocol jsocol added this to the 4.1 milestone Nov 6, 2022
@jsocol jsocol added the help-wanted open to a pull request to address this issue label Nov 6, 2022
@jsocol
Copy link
Owner

jsocol commented Nov 6, 2022

Python 2.7 is officially dropped!

@tkukushkin tkukushkin linked a pull request Jul 11, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted open to a pull request to address this issue
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

Add type hints to all public APIs tkukushkin/pystatsd
Type annotations orsinium-forks/pystatsd
3 participants
@tuukkamustonen @jsocol @orsinium