Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for es6 default import #25

Closed
CaselIT opened this issue Sep 29, 2016 · 2 comments
Closed

Add support for es6 default import #25

CaselIT opened this issue Sep 29, 2016 · 2 comments

Comments

@CaselIT
Copy link

CaselIT commented Sep 29, 2016

I was wondering if it would be possible to add module.exports.default = auth; to add support to the default es6 style import import auth from "basic-auth"

Thanks

@blakeembrey
Copy link
Member

For background, see typed-typings/npm-basic-auth#1 and typings/discussions#32. Deferring to @dougwilson's opinion as mine has been stated elsewhere, but I can elaborate if needed.

@CaselIT
Copy link
Author

CaselIT commented Sep 29, 2016

After further discussion with @blakeembrey (in typed-typings/npm-basic-auth#1) I came to the conclusion that while useful, still to many variables on the implementation of es6 in nodejs are left open, that could require the removal of the default export.

@CaselIT CaselIT closed this as completed Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants