Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unfinished] Updated error_template.html file #36

Open
jypeter opened this issue Nov 28, 2019 · 0 comments
Open

[Unfinished] Updated error_template.html file #36

jypeter opened this issue Nov 28, 2019 · 0 comments

Comments

@jypeter
Copy link

jypeter commented Nov 28, 2019

I have saved this issue with an [Unfinished] tag at the beginning of the subject, because I have not had time to fully write the issue, but I'd rather not lose it if my browser crashes...

I have corrected some errors in error_template.html . At least the most obvious errors (I have probably missed some, since I have not coded html directly for some time). These errors did not prevent the pages from displaying but you'll see that the page looks slightly different now

Corrected error template page including the suggested time information in #32

Corrected errors:

  • missing closing </html> tag at the end
  • missing <ul> and </ul> tags around the <li>list items</li>. Use ol (ordered list) instead of ul if you want numbers instead of bullets
  • removed unnecessary <a> and </a> tags around strings that were not linking to anything

Improvements (I hope)

  • used relative (%) rather than absolute (px) specification in some style definitions, in order to improve browser window resizing and have a slightly more compact look (especially for smaller browser windows)
  • Defined a CSS style for p
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant