You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
I could not reopen #725 but I think the issue is still there, because this interpolation causes wrong dependencies versions in the changelogs:
when setting "tagPrefix": "{projectName}@" in the config file, the versionTagPrefix that comes as argument of the version function is already interpolated as the project name:
So all the calls to formatTagPrefix do nothing because the {projectName} has already been interpolated. In particular when searching for the latest version of the dependencies, since the tagPrefix is the one of the parent and not the dependency (as it should be), all dependencies versions get resolved to the one of the parent :
This causes wrong versions in the changelog: {dependency} updated to version {latest version of parent}.
The easy workaround is to not override the tagPrefix in the config.
I guess the fix might not be trivial, if not breaking, but I think at least mentioning the issue in the docs would prevent a few headaches. Thanks !
The text was updated successfully, but these errors were encountered:
Hi,
I could not reopen #725 but I think the issue is still there, because this interpolation causes wrong dependencies versions in the changelogs:
when setting
"tagPrefix": "{projectName}@"
in the config file, theversionTagPrefix
that comes as argument of theversion
function is already interpolated as the project name:semver/packages/semver/src/executors/version/index.ts
Line 240 in 885f26d
So all the calls to formatTagPrefix do nothing because the
{projectName}
has already been interpolated. In particular when searching for the latest version of the dependencies, since thetagPrefix
is the one of the parent and not the dependency (as it should be), all dependencies versions get resolved to the one of the parent :semver/packages/semver/src/executors/version/utils/try-bump.ts
Lines 332 to 346 in 885f26d
This causes wrong versions in the changelog:
{dependency} updated to version {latest version of parent}
.The easy workaround is to not override the
tagPrefix
in the config.I guess the fix might not be trivial, if not breaking, but I think at least mentioning the issue in the docs would prevent a few headaches. Thanks !
The text was updated successfully, but these errors were encountered: