From 03e4617c59058d105ac1b325cb24198dbe403878 Mon Sep 17 00:00:00 2001 From: Jonathan Schwender Date: Sun, 19 Nov 2023 15:53:02 +0100 Subject: [PATCH] Don't set `AR` for `msvc` targets --- cmake/Corrosion.cmake | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmake/Corrosion.cmake b/cmake/Corrosion.cmake index 6185652c..560fb754 100644 --- a/cmake/Corrosion.cmake +++ b/cmake/Corrosion.cmake @@ -783,7 +783,9 @@ function(_add_cargo_build out_cargo_build_out_dir) if(CMAKE_CXX_COMPILER) list(APPEND corrosion_cc_rs_flags "CXX_${_CORROSION_RUST_CARGO_TARGET_UNDERSCORE}=${CMAKE_CXX_COMPILER}") endif() - if(CMAKE_AR) + # cc-rs doesn't seem to support `llvm-ar` (commandline syntax), wo we might as well just use + # the default AR. + if(CMAKE_AR AND NOT (Rust_CARGO_TARGET_ENV STREQUAL "msvc")) list(APPEND corrosion_cc_rs_flags "AR_${_CORROSION_RUST_CARGO_TARGET_UNDERSCORE}=${CMAKE_AR}") endif()