servo: Merge #17761 - Add [CEReactions] to webidls (from cbrewster:ce_reactions); r=jdm

<!-- Please describe your changes on the following line: -->
Relies on #17614

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: a6739cb17f381b88531eb6173d048868aec8e082

Author: cbrewster

servo/components/script/dom/bindings/codegen/CodegenRust.py

@@ -3152,7 +3152,7 @@ class CGCallGenerator(CGThing):
     """
     def __init__(self, errorResult, arguments, argsPre, returnType,
                  extendedAttributes, descriptor, nativeMethodName,
-                 static, object="this"):
+                 static, object="this", hasCEReactions=False):
         CGThing.__init__(self)
 
         assert errorResult is None or isinstance(errorResult, str)
@@ -3185,6 +3185,9 @@ def __init__(self, errorResult, arguments, argsPre, returnType,
             call = CGWrapper(call, pre="%s." % object)
         call = CGList([call, CGWrapper(args, pre="(", post=")")])
 
+        if hasCEReactions:
+            self.cgRoot.append(CGGeneric("push_new_element_queue();\n"))
+
         self.cgRoot.append(CGList([
             CGGeneric("let result: "),
             result,
@@ -3193,6 +3196,9 @@ def __init__(self, errorResult, arguments, argsPre, returnType,
             CGGeneric(";"),
         ]))
 
+        if hasCEReactions:
+            self.cgRoot.append(CGGeneric("pop_current_element_queue();\n"))
+
         if isFallible:
             if static:
                 glob = "global.upcast::<GlobalScope>()"
@@ -3267,11 +3273,12 @@ def __init__(self, returnType, argsPre, arguments, nativeMethodName, static,
                                                           idlNode.maplikeOrSetlikeOrIterable,
                                                           idlNode.identifier.name))
         else:
+            hasCEReactions = idlNode.getExtendedAttribute("CEReactions")
             cgThings.append(CGCallGenerator(
                 errorResult,
                 self.getArguments(), self.argsPre, returnType,
                 self.extendedAttributes, descriptor, nativeMethodName,
-                static))
+                static, hasCEReactions=hasCEReactions))
 
         self.cgRoot = CGList(cgThings, "\n")
 
@@ -5642,6 +5649,8 @@ def generate_imports(config, cgthings, descriptors, callbacks=None, dictionaries
         'dom::bindings::interface::define_guarded_properties',
         'dom::bindings::interface::html_constructor',
         'dom::bindings::interface::is_exposed_in',
+        'dom::bindings::interface::pop_current_element_queue',
+        'dom::bindings::interface::push_new_element_queue',
         'dom::bindings::iterable::Iterable',
         'dom::bindings::iterable::IteratorType',
         'dom::bindings::js::JS',

servo/components/script/dom/bindings/interface.rs

@@ -103,6 +103,7 @@ use js::jsapi::{TrueHandleValue, Value};
 use js::jsval::{JSVal, PrivateValue};
 use js::rust::{define_methods, define_properties, get_object_class};
 use libc;
+use script_thread::ScriptThread;
 use std::ptr;
 
 /// The class of a non-callback interface object.
@@ -300,6 +301,14 @@ pub unsafe fn html_constructor<T>(window: &Window, call_args: &CallArgs) -> Fall
     // Custom element upgrades are not implemented yet, so these steps are unnecessary.
 }
 
+pub fn push_new_element_queue() {
+    ScriptThread::push_new_element_queue();
+}
+
+pub fn pop_current_element_queue() {
+    ScriptThread::pop_current_element_queue();
+}
+
 /// Create and define the interface object of a callback interface.
 pub unsafe fn create_callback_interface_object(
         cx: *mut JSContext,

servo/components/script/dom/customelementregistry.rs

@@ -33,6 +33,7 @@ use microtask::Microtask;
 use script_thread::ScriptThread;
 use std::cell::Cell;
 use std::collections::{HashMap, VecDeque};
+use std::mem;
 use std::ops::Deref;
 use std::ptr;
 use std::rc::Rc;
@@ -495,18 +496,37 @@ enum BackupElementQueueFlag {
 #[derive(HeapSizeOf, JSTraceable)]
 #[must_root]
 pub struct CustomElementReactionStack {
+    stack: DOMRefCell<Vec<ElementQueue>>,
     backup_queue: ElementQueue,
     processing_backup_element_queue: Cell<BackupElementQueueFlag>,
 }
 
 impl CustomElementReactionStack {
     pub fn new() -> CustomElementReactionStack {
         CustomElementReactionStack {
+            stack: DOMRefCell::new(Vec::new()),
             backup_queue: ElementQueue::new(),
             processing_backup_element_queue: Cell::new(BackupElementQueueFlag::NotProcessing),
         }
     }
 
+    pub fn push_new_element_queue(&self) {
+        self.stack.borrow_mut().push(ElementQueue::new());
+    }
+
+    pub fn pop_current_element_queue(&self) {
+        rooted_vec!(let mut stack);
+        mem::swap(&mut *stack, &mut *self.stack.borrow_mut());
+
+        if let Some(current_queue) = stack.last() {
+            current_queue.invoke_reactions();
+        }
+        stack.pop();
+
+        mem::swap(&mut *self.stack.borrow_mut(), &mut *stack);
+        self.stack.borrow_mut().append(&mut *stack);
+    }
+
     /// https://html.spec.whatwg.org/multipage/#enqueue-an-element-on-the-appropriate-element-queue
     /// Step 4
     pub fn invoke_backup_element_queue(&self) {
@@ -519,22 +539,24 @@ impl CustomElementReactionStack {
 
     /// https://html.spec.whatwg.org/multipage/#enqueue-an-element-on-the-appropriate-element-queue
     pub fn enqueue_element(&self, element: &Element) {
-        // TODO: Steps 1 - 2
-        // Support multiple queues
-
-        // Step 1.1
-        self.backup_queue.append_element(element);
+        if let Some(current_queue) = self.stack.borrow().last() {
+            // Step 2
+            current_queue.append_element(element);
+        } else {
+            // Step 1.1
+            self.backup_queue.append_element(element);
 
-        // Step 1.2
-        if self.processing_backup_element_queue.get() == BackupElementQueueFlag::Processing {
-            return;
-        }
+            // Step 1.2
+            if self.processing_backup_element_queue.get() == BackupElementQueueFlag::Processing {
+                return;
+            }
 
-        // Step 1.3
-        self.processing_backup_element_queue.set(BackupElementQueueFlag::Processing);
+            // Step 1.3
+            self.processing_backup_element_queue.set(BackupElementQueueFlag::Processing);
 
-        // Step 4
-        ScriptThread::enqueue_microtask(Microtask::CustomElementReaction);
+            // Step 4
+            ScriptThread::enqueue_microtask(Microtask::CustomElementReaction);
+        }
     }
 
     /// https://html.spec.whatwg.org/multipage/#enqueue-a-custom-element-callback-reaction
@@ -578,9 +600,11 @@ impl CustomElementReactionStack {
                     unsafe { val.to_jsval(cx, value.handle_mut()); }
                 }
 
-                let namespace = DOMString::from(&*namespace);
-                rooted!(in(cx) let mut namespace_value = UndefinedValue());
-                unsafe { namespace.to_jsval(cx, namespace_value.handle_mut()); }
+                rooted!(in(cx) let mut namespace_value = NullValue());
+                if namespace != ns!() {
+                    let namespace = DOMString::from(&*namespace);
+                    unsafe { namespace.to_jsval(cx, namespace_value.handle_mut()); }
+                }
 
                 let args = vec![Heap::default(), Heap::default(), Heap::default(), Heap::default()];
                 args[0].set(name_value.get());

servo/components/script/dom/node.rs

@@ -1422,13 +1422,12 @@ impl Node {
             for descendant in node.traverse_preorder() {
                 descendant.set_owner_doc(document);
             }
-            for descendant in node.traverse_preorder() {
+            for descendant in node.traverse_preorder().filter_map(|d| d.as_custom_element()) {
                 // Step 3.2.
-                if let Some(element) = node.as_custom_element() {
-                    ScriptThread::enqueue_callback_reaction(&*element,
-                        CallbackReaction::Adopted(old_doc.clone(), Root::from_ref(document)));
-                }
-
+                ScriptThread::enqueue_callback_reaction(&*descendant,
+                    CallbackReaction::Adopted(old_doc.clone(), Root::from_ref(document)));
+            }
+            for descendant in node.traverse_preorder() {
                 // Step 3.3.
                 vtable_for(&descendant).adopting_steps(&old_doc);
             }
@@ -1636,9 +1635,17 @@ impl Node {
         for kid in new_nodes {
             // Step 7.1.
             parent.add_child(*kid, child);
-            // Step 7.2: insertion steps.
-            if let Some(element) = kid.as_custom_element() {
-                ScriptThread::enqueue_callback_reaction(&*element, CallbackReaction::Connected);
+            // Step 7.7.
+            for descendant in kid.traverse_preorder().filter_map(Root::downcast::<Element>) {
+                // Step 7.7.2.
+                if descendant.is_connected() {
+                    // Step 7.7.2.1.
+                    if descendant.get_custom_element_definition().is_some() {
+                        ScriptThread::enqueue_callback_reaction(&*descendant, CallbackReaction::Connected);
+                    }
+                    // TODO: Step 7.7.2.2.
+                    // Try to upgrade descendant.
+                }
             }
         }
         if let SuppressObserver::Unsuppressed = suppress_observers {

servo/components/script/dom/webidls/Attr.webidl

@@ -18,11 +18,11 @@ interface Attr {
   readonly attribute DOMString name;
   [Constant]
   readonly attribute DOMString nodeName; // historical alias of .name
-  [Pure]
+  [CEReactions, Pure]
            attribute DOMString value;
-  [Pure]
+  [CEReactions, Pure]
            attribute DOMString textContent; // historical alias of .value
-  [Pure]
+  [CEReactions, Pure]
            attribute DOMString nodeValue; // historical alias of .value
 
   [Pure]