Replace "WizardForm.Show" with "WizardForm.Visible := True".

Show has a BringToFront call that we don't need. Changing Visible from False to True already brings the window to the front when not minimized. And when it is minimized, we don't want it becoming the active window.

This works around the same VCL issue as in preceding commits, where the Forms unit's WM_ACTIVATEAPP handler sets FAppIconic=False even though the window may still be minimized, which causes the next Application.Restore call to be a no-op.

Projects/Src/Setup.MainForm.pas

@@ -119,7 +119,7 @@ procedure TMainForm.InitializeWizard;
   WizardForm.SetCurPage(wpWelcome);
   if InstallMode = imNormal then begin
     WizardForm.ClickToStartPage; { this won't go past wpReady  }
-    WizardForm.Show;
+    WizardForm.Visible := True;
   end
   else
     WizardForm.ClickThroughPages;
@@ -195,7 +195,7 @@ function TMainForm.Install: Boolean;
             else begin
               if WizardWasHidden then begin
                 WizardWasHidden := False;
-                WizardForm.Show;
+                WizardForm.Visible := True;
               end;
             end;
             DebugNotifyEntry(seRun, I);
@@ -206,7 +206,7 @@ function TMainForm.Install: Boolean;
         end;
       finally
         if WizardWasHidden then
-          WizardForm.Show;
+          WizardForm.Visible := True;
         WindowDisabler.Free;
         if CheckIfRestartNeeded then begin
           ChecksumAfter := MakePendingFileRenameOperationsChecksum;
@@ -276,7 +276,7 @@ function TMainForm.Install: Boolean;
 
     Application.Restore;
     if InstallMode = imSilent then
-      WizardForm.Show;
+      WizardForm.Visible := True;
     WizardForm.Update;
 
     SetStep(ssInstall, False);

Projects/Src/Setup.WizardForm.pas

@@ -1839,7 +1839,7 @@ function TWizardForm.PrepareToInstall(const WizardComponents, WizardTasks: TStri
     NextButton.Visible := False;
     CancelButton.Enabled := False;
     if InstallMode = imSilent then
-      WizardForm.Show;
+      WizardForm.Visible := True;
     WizardForm.Update;
     try
       DownloadTemporaryFileOrExtract7ZipArchiveProcessMessages := True;
@@ -2532,7 +2532,7 @@ procedure TWizardForm.NextButtonClick(Sender: TObject);
               BackButton.Visible := False;
               NextButton.Visible := False;
               if InstallMode = imSilent then
-                WizardForm.Show;
+                WizardForm.Visible := True;
               try
                 WizardForm.Update;
                 RmFoundApplications := QueryRestartManager(WizardComponents, WizardTasks) <> '';
@@ -3020,12 +3020,10 @@ procedure TWizardForm.ClickThroughPages;
         { After installation, we can't abort since e.g. a restart might be
           needed. Instead, to avoid getting stuck in a loop, show the wizard
           (even though this is a silent install) and let the user deal with the
-          problem on their own.
-          The taskbar button will be hidden at this point on very silent
-          installs (see SetupInstallMode); re-show it. }
+          problem on their own. }
         Log('Failed to proceed to next wizard page; showing wizard.');
+        WizardForm.Visible := True;
         Application.Restore;
-        WizardForm.Show;
         Break;
       end;
     end;