Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential bug with ContractConfigurator.Parameters.VesselNotDestroyed.OnPartJointBreak #716

Open
pehvbot opened this issue Apr 11, 2022 · 0 comments
Open

Potential bug with ContractConfigurator.Parameters.VesselNotDestroyed.OnPartJointBreak #716

pehvbot opened this issue Apr 11, 2022 · 0 comments

Comments

@pehvbot
Copy link

pehvbot commented Apr 11, 2022

I'm not 100% certain about this one since I haven't fully explored this, but it looks like Parameters.VesselNotDestroyed.OnPartJointBreak is throwing a NullReferenceException in the VAB when merged vessels or subassemblies are used. Looking at VesselNotDestroyed.cs, I think it should be checking HighLogic.LoadedScene == GameScenes.EDITOR for cases like this. I haven't really dug into this too much so apologies if I got this one wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pehvbot