Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vessel state change causes bugs for VesselParameterGroups #715

Open
Teykn opened this issue Feb 7, 2022 · 2 comments
Open

Vessel state change causes bugs for VesselParameterGroups #715

Teykn opened this issue Feb 7, 2022 · 2 comments

Comments

@Teykn
Copy link

Teykn commented Feb 7, 2022

Heyo,

I was testing a contract that has 2 VesselParameterGroups, one that defines a vessel and another that uses that vessel. There’s one child parameter that is mutually exclusive between both VPGs. (VPG 1 is uncrewed, VPG 2 requires two crewmembers)

In testing, I noticed that when VPG 1 is satisfied the child parameters in VPG 2 would be completed despite the vessel not being able to satisfy all the parameters.

tl;dr Completing a VPG that defines a vessel automatically completes all child parameters in a VPG that uses the vessel despite some child parameters not being satisfied.

@Teykn
Copy link
Author

Teykn commented Feb 22, 2022

Did some testing, it seems that the only way to fix this is by adding completeInSequence = true in the child parameters. I'm not sure if this is intended behavior, especially since child parameters seem to be completed when they shouldn't be (e.g. 2 crew parameter being satisfied while vessel is uncrewed).

@siimav
Copy link

siimav commented Dec 9, 2022

Possibly related? KSP-RO#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants