Tests failing (3 to 7, Windows)

[chwt]

Diagnostic output

jrnl: v4.1
Python: 3.10.11 (tags/v3.10.11:7d4cc5a, Apr 5 2023, 00:38:17) [MSC v.1929 64 bit (AMD64)]
OS: Windows 10

(note: it is Windows 11)

What are you trying to do?

Running both

• poe test
• pytest

on current develop branch return failed tests.
Running from both PowerShell 7.4.5 and WSL (EDIT: got it to work in WSL, see #1917 (comment))

poe summary:

========================================================================================================================= short test summary info ==========================================================================================================================
FAILED tests/bdd/test_features.py::test_printing_a_journal_that_has_multiline_entries_with_tags[basic_folder.yaml] - AssertionError: assert '2020-08-29 1...os himenaeos.' == '2020-08-29 1...os himenaeos.'
FAILED tests/bdd/test_features.py::test_printing_a_journal_that_has_multiline_entries_with_tags[basic_dayone.yaml] - AssertionError: assert '2020-08-29 1...os himenaeos.' == '2020-08-29 1...os himenaeos.'
FAILED tests/bdd/test_features.py::test_combining_changetime_and_delete_and_edit_affects_appropriate_entries[basic_folder.yaml] - AssertionError:
FAILED tests/bdd/test_features.py::test_printing_a_journal_that_has_multiline_entries_with_tags[basic_onefile.yaml] - AssertionError: assert '2020-08-29 1...os himenaeos.' == '2020-08-29 1...os himenaeos.'
FAILED tests/bdd/test_features.py::test_printing_a_journal_that_has_multiline_entries_with_tags[basic_encrypted.yaml] - AssertionError: assert '2020-08-29 1...os himenaeos.' == '2020-08-29 1...os himenaeos.'
FAILED tests/bdd/test_features.py::test_writing_into_dayone - AssertionError: assert '1979-05-01 0...g born hurts.' == '1979-05-01 0...g born hurts.'
FAILED tests/bdd/test_features.py::test_count_modifications_when_editing_whole_journal_and_adding_to_last_entry[basic_folder.yaml] - AssertionError:
================================================================================================================ 7 failed, 634 passed, 44 skipped in 18.36s ================================================================================================================

test-failure-poe.txt

pytest summary:

=========================================================================================== short test summary info ============================================================================================
FAILED tests/bdd/test_features.py::test_combining_changetime_and_delete_and_edit_affects_appropriate_entries[basic_folder.yaml] - AssertionError:
FAILED tests/bdd/test_features.py::test_writing_into_dayone - AssertionError: assert '1979-05-01 0...g born hurts.' == '1979-05-01 0...g born hurts.'
FAILED tests/bdd/test_features.py::test_count_modifications_when_editing_whole_journal_and_adding_to_last_entry[basic_folder.yaml] - AssertionError:
================================================================================== 3 failed, 638 passed, 44 skipped in 19.61s ==================================================================================

test-failure-pytest.txt

What have you tried?

n/a

Other Information

No response

[micahellison]

Hi @chwt, sorry for the slow response. I have various issues with tests failing on Windows also, though my error messages are different, and it's only when running poe test. Weirdly, the Windows Server machines that run our tests on GitHub seem to be fine, so I always thought it was just something odd about my environment.

Running poe test on Windows uses tox, which I think is the main problem with these errors. tox has features related to colors and screen sizes that I think work better in Linux than Windows, and jrnl has behaviors that vary based on these things, which is why I believe it's an issue. Because of these problems, I bypass this process in my local Windows environment. I would think that your WSL environment would still work, though, if you're running all your commands in Linux.

Do you use poetry to run pytest? I wonder if that's the cause of the errors you're getting when running pytest by itself, since it might be missing dependencies if not. Still, I'd expect different test failures if that was the case.

Also, I wonder if these tests are locale-specific. When I run Get-WinSystemLocale in PowerShell my locale name is en-US. Maybe if yours is different, that could explain some of these errors.

You might have better luck with a more recent version of Python. While jrnl technically supports Python 3.10 now, we will be dropping support for it soon within the next year.

[chwt]

No worries @micahellison !

Regarding Win native:
Get-WinSystemLocale is also for me en-US. Though my Get-Culture is a different one, in case that is relevant.

Actually, based on your comments I retried it on WSL. I am not sure anymore if I really set it up correctly before.
After Ubuntu upgrade having then:

platform linux -- Python 3.12.8, pytest-8.0.2, pluggy-1.5.0
plugins: xdist-3.6.1, bdd-7.3.0

(note: had to add <8.0 limit for the bdd version)

poetry run poe test worked:

======================================================================================== 663 passed, 40 skipped in 4.55s ========================================================================================
  py: OK (13.23 seconds)
  congratulations :) (13.29 seconds)

👍