Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ssl connections #284

Open
gtnx opened this issue Dec 17, 2018 · 4 comments
Open

Handle ssl connections #284

gtnx opened this issue Dec 17, 2018 · 4 comments

Comments

@gtnx
Copy link
Collaborator

gtnx commented Dec 17, 2018

As far as i understand, it looks impossible to use this library with SSL redis connections.

The reason is that settings.WS4REDIS_CONNECTION is used to instantiate:

The reason is that those two objects does not have the same signature for handling ssl connections:

I propose to use one of the two conventions (the ssl flag for instance which is easier to understand) and adapt code in wsgi_server.py.

What do you think?

@jrief
Copy link
Owner

jrief commented Dec 17, 2018

from my point of view, I never saw the need to connect Redis through SSL, since it typically runs on the same host as the application server. How is your use-case / architecture?

@gtnx
Copy link
Collaborator Author

gtnx commented Dec 18, 2018

In our usecase, we use a managed Redis on Azure platform. By default Azure, only opens the 6380 port (dedicated to SSL connections. We don't want to use non-ssl port (6379) as we don't have a private network in this usecase.

@jrief
Copy link
Owner

jrief commented Dec 19, 2018

OK. This is a really valid use-case. I would have to dig into this topic. Do you have time to create a pull-request?

@gtnx
Copy link
Collaborator Author

gtnx commented Dec 19, 2018

Yes i'll do it today

gtnx added a commit to gtnx/django-websocket-redis that referenced this issue Dec 19, 2018
* `RedisPublisher` handles `ssl` flag
* Update docs
gtnx added a commit to gtnx/django-websocket-redis that referenced this issue May 25, 2019
* `RedisPublisher` handles `ssl` flag
* Update docs
jrief added a commit that referenced this issue May 3, 2023
Issue #284 Handle ssl connections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants