Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recrusive formula for z-function in TS/KMN starting conditions does not match actual #42

Open
jrenaud90 opened this issue Feb 5, 2024 · 0 comments
Open

Recrusive formula for z-function in TS/KMN starting conditions does not match actual #42

jrenaud90 opened this issue Feb 5, 2024 · 0 comments
Labels
Question Further information is requested

Comments

@jrenaud90
Copy link
Owner

The recrusision formula shown in TS72 and KMN15 (See TS72 Eq. 97) does not reproduce the full version of this function (TS72 Eq. 96). I am finding it to be off by about 30% at l = 2 and then the error improves to 10% at l=10. Perhaps thre is a problem with the implementation.

For this reason, for now, TidalPy does not use this recrusive formula (see cf_z_calc in "RadialSolver.starting.common.pyx").
@jrenaud90 jrenaud90 added the Question Further information is requested label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrenaud90