wrong variable being compared

[Hallocoos]

Hi! Error I found in this function. https://github.com/jraleman/42_Exam-C/edit/master/level02/max.c

In this function, the while loop should be:
while (len--)
{
if (maxvalue < tab[i])
maxvalue = tab[i];
i++;
}
otherwise it only ends up comparing the last two integers in the array and returns the wrong result.

[jraleman]

Nice catch! Feel free to make a PR if you want to. :]

[Hallocoos]

Sorry, what is a PR?

…

On Wed, Jul 24, 2019, 10:09 Jose Ramon Aleman ***@***.***> wrote: Nice catch! Feel free to make a PR if you want to. :] — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK6FMA7YWGUQZRLBQ24MFETQBAE4VANCNFSM4IGD4QKA> .

[jraleman]

Sorry, what is a PR?
…
On Wed, Jul 24, 2019, 10:09 Jose Ramon Aleman @.***> wrote: Nice catch! Feel free to make a PR if you want to. :] — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AK6FMA3LMQWCQQLFB4AZKDDQBAE4VA5CNFSM4IGD4QKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2VRCRA#issuecomment-514527556>, or mute the thread https://github.com/notifications/unsubscribe-auth/AK6FMA7YWGUQZRLBQ24MFETQBAE4VANCNFSM4IGD4QKA .

It's a pull request.
So first, you want to make a fork of the repo, and make the changes in your repo, preferable in a new branch.
Commit the changes and do a pull request to this repo.

[Hallocoos]

Ooh, I'll do that from now on! Thanks for the info! On Sat, Jul 27, 2019, 08:03 Jose Ramon Aleman <[email protected]> wrote:

…

Sorry, what is a PR? … <#m_-5655568273465604577_> On Wed, Jul 24, 2019, 10:09 Jose Ramon Aleman *@*.***> wrote: Nice catch! Feel free to make a PR if you want to. :] — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < #12 <#12>, or mute the thread https://github.com/notifications/unsubscribe-auth/AK6FMA7YWGUQZRLBQ24MFETQBAE4VANCNFSM4IGD4QKA . It's a pull request. So first, you want to make a fork of the repo, and make the changes in your repo, preferable in a new branch. Commit the changes and do a pull request to this repo. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK6FMA3HJAF2QRQ4HPJCJPDQBPQK5ANCNFSM4IGD4QKA> .