Skip to content

Commit 8dc5f87

Browse files
committed
Build: Remove --production flag to fix grunt prepare
I don't know how long this has been broken for, but, `--production` is incompatible with grunt-check-modules as used in the download.jqueryui.com package for the `grunt prepare` step. Test Plan * `apt-get install -y libxml2-utils xsltproc imagemagick` * Create `config.json` * Run `npx grunt build` ``` Running "build-download" task Initializing download module, might take a while... >> Running "check-modules" task >> Warning: Command failed: npm ls >> npm ERR! code ELSPROBLEMS >> npm ERR! missing: [email protected], required by [email protected] ```
1 parent 1e7153f commit 8dc5f87

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

Gruntfile.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ grunt.registerTask( "build-download", function() {
6464

6565
// At this point, the download builder repo is available, so let's initialize it
6666
grunt.log.writeln( "Initializing download module, might take a while..." );
67-
exec( "npm install --production", {
67+
// TODO: Prefer --omit=dev but can't because `grunt prepare` runs grunt-check-modules,
68+
// which fails if a dev dependency is missing.
69+
exec( "npm install", {
6870
cwd: "node_modules/download.jqueryui.com"
6971
}, function( error, stdout, stderr ) {
7072
if ( error ) {

README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,10 @@
33
## Building and Deploying
44

55
To build and deploy your changes for previewing in a [`jquery-wp-content`](https://github.com/jquery/jquery-wp-content) instance, follow the [workflow instructions](http://contribute.jquery.org/web-sites/#workflow) from our documentation on [contributing to jQuery Foundation web sites](http://contribute.jquery.org/web-sites/).
6+
7+
Prerequisites:
8+
* `apt-get install -y libxml2-utils xsltproc imagemagick`
9+
* Create `config.json`
10+
11+
Build the dist directory locally:
12+
* `npx grunt build`

0 commit comments

Comments
 (0)