From f6490d5f432b1712bb4924208377b710305a9a29 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Go=C5=82e=CC=A8biowski-Owczarek?=
 <m.goleb@gmail.com>
Date: Tue, 10 Sep 2024 00:15:24 +0200
Subject: [PATCH] Effect: Remove demos & visual tests of the transfer effect

The transfer effect is deprecated and not present unless `$.uiBackCompat` is set
to `true`. In previous UI versions, the default was including the backwards
compat layer so these demos & tests worked; now they do not by default. Just
remove them.

Fixes gh-2278
---
 demos/effect/default.html       | 4 ----
 tests/visual/effects/all.html   | 6 ------
 tests/visual/effects/effects.js | 8 --------
 3 files changed, 18 deletions(-)

diff --git a/demos/effect/default.html b/demos/effect/default.html
index 7d69abb2d76..289d5df7ff0 100644
--- a/demos/effect/default.html
+++ b/demos/effect/default.html
@@ -11,7 +11,6 @@
 		#button { padding: .5em 1em; text-decoration: none; }
 		#effect { width: 240px; height: 170px; padding: 0.4em; position: relative; }
 		#effect h3 { margin: 0; padding: 0.4em; text-align: center; }
-		.ui-effects-transfer { border: 2px dotted gray; }
 	</style>
 	<script src="../../external/requirejs/require.js"></script>
 	<script src="../bootstrap.js" data-modules="effects-all">
@@ -25,8 +24,6 @@
 			// some effects have required parameters
 			if ( selectedEffect === "scale" ) {
 				options = { percent: 50 };
-			} else if ( selectedEffect === "transfer" ) {
-				options = { to: "#button", className: "ui-effects-transfer" };
 			} else if ( selectedEffect === "size" ) {
 				options = { to: { width: 200, height: 60 } };
 			}
@@ -75,7 +72,6 @@ <h3 class="ui-widget-header ui-corner-all">Effect</h3>
 	<option value="shake">Shake</option>
 	<option value="size">Size</option>
 	<option value="slide">Slide</option>
-	<option value="transfer">Transfer</option>
 </select>
 
 <button id="button" class="ui-state-default ui-corner-all">Run Effect</button>
diff --git a/tests/visual/effects/all.html b/tests/visual/effects/all.html
index e3fa3ee487f..f4f9c270eba 100644
--- a/tests/visual/effects/all.html
+++ b/tests/visual/effects/all.html
@@ -169,12 +169,6 @@
 		</div>
 	</li>
 
-	<li>
-		<div class="effect" id="transfer">
-		<p>Transfer to first element</p>
-		</div>
-	</li>
-
 	<li>
 		<div class="effect" id="addClass">
 		<p>addClass</p>
diff --git a/tests/visual/effects/effects.js b/tests/visual/effects/effects.js
index ebe3347f286..5e8390abe12 100644
--- a/tests/visual/effects/effects.js
+++ b/tests/visual/effects/effects.js
@@ -83,14 +83,6 @@ effect( "#slideUp", "slide", { direction: "up" } );
 effect( "#slideLeft", "slide", { direction: "left" } );
 effect( "#slideRight", "slide", { direction: "right" } );
 
-$( "#transfer" ).on( "click", function() {
-	$( this )
-		.addClass( "current" )
-		.effect( "transfer", { to: $( "div" ).eq( 0 ) }, 1000, function() {
-			$( this ).removeClass( "current" );
-		} );
-} );
-
 $( "#addClass" ).on( "click", function() {
 	$( this ).addClass( "current", duration, function() {
 		$( this ).removeClass( "current" );