From a8a6e2612e1e2fa89e742b3180880eb47b3e6f2c Mon Sep 17 00:00:00 2001 From: Ralf Koller Date: Fri, 24 May 2024 03:47:50 +0200 Subject: [PATCH 01/15] Add aria-modal attribute true to dialog modal wrapper --- ui/widgets/dialog.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/widgets/dialog.js b/ui/widgets/dialog.js index 4ba9d11176..cf2b42f709 100644 --- a/ui/widgets/dialog.js +++ b/ui/widgets/dialog.js @@ -347,7 +347,8 @@ $.widget( "ui.dialog", { // Setting tabIndex makes the div focusable tabIndex: -1, - role: "dialog" + role: "dialog", + "aria-modal": "true" } ) .appendTo( this._appendTo() ); From 729c6d0a5330c75af5f05b4b7dc07f60c55edf7d Mon Sep 17 00:00:00 2001 From: Ralf Koller Date: Fri, 24 May 2024 03:49:58 +0200 Subject: [PATCH 02/15] Add a test if aria-modal attribute is there and true --- tests/unit/dialog/core.js | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index d307504b80..e408f087ad 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -75,6 +75,7 @@ QUnit.test( "ARIA", function( assert ) { var element = $( "
" ).dialog(), wrapper = element.dialog( "widget" ); assert.equal( wrapper.attr( "role" ), "dialog", "dialog role" ); + assert.equal( wrapper.attr( "aria-modal" ), "true", "aria-modal attribute" ); assert.equal( wrapper.attr( "aria-labelledby" ), wrapper.find( ".ui-dialog-title" ).attr( "id" ) ); assert.equal( wrapper.attr( "aria-describedby" ), element.attr( "id" ), "aria-describedby added" ); element.remove(); From 268dc6287753890fdaf516399f6d685f8b7b7896 Mon Sep 17 00:00:00 2001 From: Ralf Koller Date: Fri, 24 May 2024 17:54:17 +0200 Subject: [PATCH 03/15] fix: increasing # of expected asserts from 4 to 5 --- tests/unit/dialog/core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index e408f087ad..66426a0622 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -70,7 +70,7 @@ QUnit.test( "title id", function( assert ) { } ); QUnit.test( "ARIA", function( assert ) { - assert.expect( 4 ); + assert.expect( 5 ); var element = $( "
" ).dialog(), wrapper = element.dialog( "widget" ); From 7f88e7f62feaf653f870d79725d7691c91783c42 Mon Sep 17 00:00:00 2001 From: Ralf Koller <1665422+rpkoller@users.noreply.github.com> Date: Fri, 31 May 2024 13:24:31 +0200 Subject: [PATCH 04/15] only add aria-modal when this.options.modal is set to true MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit suggestion by @mgol Co-authored-by: Michał Gołębiowski-Owczarek --- ui/widgets/dialog.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/widgets/dialog.js b/ui/widgets/dialog.js index cf2b42f709..db940f2f9d 100644 --- a/ui/widgets/dialog.js +++ b/ui/widgets/dialog.js @@ -348,7 +348,7 @@ $.widget( "ui.dialog", { // Setting tabIndex makes the div focusable tabIndex: -1, role: "dialog", - "aria-modal": "true" + "aria-modal": this.options.modal ? "true" : null } ) .appendTo( this._appendTo() ); From 22ea1a70380ae5ff9b2414c03ece783480a715f4 Mon Sep 17 00:00:00 2001 From: Ralf Koller Date: Fri, 7 Jun 2024 23:25:04 +0200 Subject: [PATCH 05/15] revert the ARIA test back to its initial form per @mgols recommendation --- tests/unit/dialog/core.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index 66426a0622..d307504b80 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -70,12 +70,11 @@ QUnit.test( "title id", function( assert ) { } ); QUnit.test( "ARIA", function( assert ) { - assert.expect( 5 ); + assert.expect( 4 ); var element = $( "
" ).dialog(), wrapper = element.dialog( "widget" ); assert.equal( wrapper.attr( "role" ), "dialog", "dialog role" ); - assert.equal( wrapper.attr( "aria-modal" ), "true", "aria-modal attribute" ); assert.equal( wrapper.attr( "aria-labelledby" ), wrapper.find( ".ui-dialog-title" ).attr( "id" ) ); assert.equal( wrapper.attr( "aria-describedby" ), element.attr( "id" ), "aria-describedby added" ); element.remove(); From 546144d55c9995fb8380b517e261b886e2e1d651 Mon Sep 17 00:00:00 2001 From: Ralf Koller Date: Tue, 11 Jun 2024 22:40:43 +0200 Subject: [PATCH 06/15] Initial draft for the aria-modal test --- tests/unit/dialog/core.js | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index d307504b80..4ebbf78086 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -84,6 +84,26 @@ QUnit.test( "ARIA", function( assert ) { element.remove(); } ); +QUnit.test( "aria-modal", function( assert ) { + assert.expect( 3 ); + + var element = $( "
" ).dialog(), + wrapper = element.dialog( "option", "modal", true ); + assert.equal( wrapper.attr( "aria-modal" ), "true", "aria-modal attribute set to true" ); + element.remove(); + + var element = $( "
" ).dialog(), + wrapper = element.dialog( "option", "modal", false ); + assert.equal( wrapper.attr( "aria-modal" ), "false", "aria-modal attribute set to false" ); + element.remove(); + + var element = $( "
" ).dialog(); + assert.equal( element.dialog( "widget" ).attr( "aria-describedby" ), null, "no aria-modal attribute added" ); + element.remove(); + +} ); + + QUnit.test( "widget method", function( assert ) { assert.expect( 1 ); var dialog = $( "
" ).appendTo( "#qunit-fixture" ).dialog(); From 2506b1c82ad51f2b535cd04e55c61b53bbae14d2 Mon Sep 17 00:00:00 2001 From: Ralf Koller Date: Tue, 11 Jun 2024 23:38:57 +0200 Subject: [PATCH 07/15] Fixing initial draft that contained odd unintended changes --- tests/unit/dialog/core.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index 4ebbf78086..5b63227e01 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -87,20 +87,20 @@ QUnit.test( "ARIA", function( assert ) { QUnit.test( "aria-modal", function( assert ) { assert.expect( 3 ); - var element = $( "
" ).dialog(), - wrapper = element.dialog( "option", "modal", true ); - assert.equal( wrapper.attr( "aria-modal" ), "true", "aria-modal attribute set to true" ); + var element = $( "
" ).dialog( "option", "modal", true ), + wrapper = element.dialog( "widget" ); + assert.equal( wrapper.attr( "aria-modal" ), "true", "aria-modal attribute set to true" ); element.remove(); - var element = $( "
" ).dialog(), - wrapper = element.dialog( "option", "modal", false ); - assert.equal( wrapper.attr( "aria-modal" ), "false", "aria-modal attribute set to false" ); + var element = $( "
" ).dialog( "option", "modal", false ), + wrapper = element.dialog( "widget" ); + assert.equal( wrapper.attr( "aria-modal" ), "false", "aria-modal attribute set to false" ); element.remove(); - var element = $( "
" ).dialog(); - assert.equal( element.dialog( "widget" ).attr( "aria-describedby" ), null, "no aria-modal attribute added" ); + var element = $( "
" ).dialog( "option", "modal", null ), + wrapper = element.dialog( "widget" ); + assert.equal( wrapper.attr( "aria-modal" ), null, "no aria-modal attribute added" ); element.remove(); - } ); From 481006521b08b9de5fc58327c4be1c7a3836d238 Mon Sep 17 00:00:00 2001 From: Ralf Koller Date: Wed, 12 Jun 2024 02:06:21 +0200 Subject: [PATCH 08/15] change option to options for the dialog modal options --- tests/unit/dialog/core.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index 5b63227e01..6514512643 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -87,17 +87,17 @@ QUnit.test( "ARIA", function( assert ) { QUnit.test( "aria-modal", function( assert ) { assert.expect( 3 ); - var element = $( "
" ).dialog( "option", "modal", true ), + var element = $( "
" ).dialog( "options", "modal", true ), wrapper = element.dialog( "widget" ); assert.equal( wrapper.attr( "aria-modal" ), "true", "aria-modal attribute set to true" ); element.remove(); - var element = $( "
" ).dialog( "option", "modal", false ), + var element = $( "
" ).dialog( "options", "modal", false ), wrapper = element.dialog( "widget" ); assert.equal( wrapper.attr( "aria-modal" ), "false", "aria-modal attribute set to false" ); element.remove(); - var element = $( "
" ).dialog( "option", "modal", null ), + var element = $( "
" ).dialog( "options", "modal", null ), wrapper = element.dialog( "widget" ); assert.equal( wrapper.attr( "aria-modal" ), null, "no aria-modal attribute added" ); element.remove(); From 8283b78e585557a5d9b97bfc9c1ddd81a1c50878 Mon Sep 17 00:00:00 2001 From: Ralf Koller Date: Fri, 14 Jun 2024 04:44:54 +0200 Subject: [PATCH 09/15] Add check for modal to _setOption method --- ui/widgets/dialog.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ui/widgets/dialog.js b/ui/widgets/dialog.js index db940f2f9d..756ad1cb10 100644 --- a/ui/widgets/dialog.js +++ b/ui/widgets/dialog.js @@ -763,6 +763,10 @@ $.widget( "ui.dialog", { if ( key === "title" ) { this._title( this.uiDialogTitlebar.find( ".ui-dialog-title" ) ); } + + if ( key === "modal" ) { + uiDialog.attr( "aria-modal", value ? "true" : null ); + } }, _size: function() { From 42edf77bc3d5b40dfc492a363b8df868f3140a00 Mon Sep 17 00:00:00 2001 From: Ralf Koller Date: Fri, 14 Jun 2024 04:58:22 +0200 Subject: [PATCH 10/15] applying mgol's suggested changes to the aria-modal test --- tests/unit/dialog/core.js | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index 6514512643..37665c3409 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -85,25 +85,42 @@ QUnit.test( "ARIA", function( assert ) { } ); QUnit.test( "aria-modal", function( assert ) { - assert.expect( 3 ); + assert.expect( 12 ); - var element = $( "
" ).dialog( "options", "modal", true ), + var element = $( "
" ).dialog( { modal: true } ), wrapper = element.dialog( "widget" ); - assert.equal( wrapper.attr( "aria-modal" ), "true", "aria-modal attribute set to true" ); + assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); + element.dialog( "option", "modal", false ); + assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" ); + element.dialog( "option", "modal", null ); + assert.ok( !wrapper.attr( "aria-modal" ), "modal option not set, aria-modal attribute not added" ); + element.dialog( "option", "modal", true ); + assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); element.remove(); - var element = $( "
" ).dialog( "options", "modal", false ), + var element = $( "
" ).dialog( { modal: false } ), wrapper = element.dialog( "widget" ); - assert.equal( wrapper.attr( "aria-modal" ), "false", "aria-modal attribute set to false" ); + assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" ); + element.dialog( "option", "modal", true ); + assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); + element.dialog( "option", "modal", null ); + assert.ok( !wrapper.attr( "aria-modal" ), "modal option not set, aria-modal attribute not added" ); + element.dialog( "option", "modal", false ); + assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" ); element.remove(); - var element = $( "
" ).dialog( "options", "modal", null ), + var element = $( "
" ).dialog(), wrapper = element.dialog( "widget" ); - assert.equal( wrapper.attr( "aria-modal" ), null, "no aria-modal attribute added" ); + assert.ok( !wrapper.attr( "aria-modal" ), "modal option not set, aria-modal attribute not added" ); + element.dialog( "option", "modal", true ); + assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); + element.dialog( "option", "modal", false ); + assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" ); + element.dialog( "option", "modal", null ); + assert.equal( wrapper.attr( "aria-modal" ), null, "modal option not set, aria-modal attribute not added" ); element.remove(); } ); - QUnit.test( "widget method", function( assert ) { assert.expect( 1 ); var dialog = $( "
" ).appendTo( "#qunit-fixture" ).dialog(); From 174bb27b2bb65e5c5d6bd8074988840576de8cfd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82=C4=99biowski-Owczarek?= Date: Fri, 14 Jun 2024 12:42:30 +0200 Subject: [PATCH 11/15] Apply suggestions from code review --- tests/unit/dialog/core.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index 37665c3409..5dd912e80a 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -91,31 +91,31 @@ QUnit.test( "aria-modal", function( assert ) { wrapper = element.dialog( "widget" ); assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); element.dialog( "option", "modal", false ); - assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" ); + assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" ); element.dialog( "option", "modal", null ); - assert.ok( !wrapper.attr( "aria-modal" ), "modal option not set, aria-modal attribute not added" ); + assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option not set, aria-modal attribute not added" ); element.dialog( "option", "modal", true ); assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); element.remove(); var element = $( "
" ).dialog( { modal: false } ), wrapper = element.dialog( "widget" ); - assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" ); + assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" ); element.dialog( "option", "modal", true ); assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); element.dialog( "option", "modal", null ); - assert.ok( !wrapper.attr( "aria-modal" ), "modal option not set, aria-modal attribute not added" ); + assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option not set, aria-modal attribute not added" ); element.dialog( "option", "modal", false ); - assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" ); + assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" ); element.remove(); var element = $( "
" ).dialog(), wrapper = element.dialog( "widget" ); - assert.ok( !wrapper.attr( "aria-modal" ), "modal option not set, aria-modal attribute not added" ); + assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option not set, aria-modal attribute not added" ); element.dialog( "option", "modal", true ); assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); element.dialog( "option", "modal", false ); - assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" ); + assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" ); element.dialog( "option", "modal", null ); assert.equal( wrapper.attr( "aria-modal" ), null, "modal option not set, aria-modal attribute not added" ); element.remove(); From e42ab78f1cf97cfc54168a7c62a7c08aa1ea4174 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82=C4=99biowski-Owczarek?= Date: Fri, 14 Jun 2024 12:48:34 +0200 Subject: [PATCH 12/15] Avoid setting the modal option to null --- tests/unit/dialog/core.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index 5dd912e80a..bab843efeb 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -92,8 +92,6 @@ QUnit.test( "aria-modal", function( assert ) { assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); element.dialog( "option", "modal", false ); assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" ); - element.dialog( "option", "modal", null ); - assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option not set, aria-modal attribute not added" ); element.dialog( "option", "modal", true ); assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); element.remove(); @@ -103,8 +101,6 @@ QUnit.test( "aria-modal", function( assert ) { assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" ); element.dialog( "option", "modal", true ); assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); - element.dialog( "option", "modal", null ); - assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option not set, aria-modal attribute not added" ); element.dialog( "option", "modal", false ); assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" ); element.remove(); @@ -116,8 +112,6 @@ QUnit.test( "aria-modal", function( assert ) { assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); element.dialog( "option", "modal", false ); assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" ); - element.dialog( "option", "modal", null ); - assert.equal( wrapper.attr( "aria-modal" ), null, "modal option not set, aria-modal attribute not added" ); element.remove(); } ); From 3da0e24fa323f0063aa6e2bfaad86a4026a37d3c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82=C4=99biowski-Owczarek?= Date: Fri, 14 Jun 2024 12:48:48 +0200 Subject: [PATCH 13/15] Update tests/unit/dialog/core.js --- tests/unit/dialog/core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index bab843efeb..945d4f6b2b 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -85,7 +85,7 @@ QUnit.test( "ARIA", function( assert ) { } ); QUnit.test( "aria-modal", function( assert ) { - assert.expect( 12 ); + assert.expect( 9 ); var element = $( "
" ).dialog( { modal: true } ), wrapper = element.dialog( "widget" ); From 67490a00a68f86f35fe2dc056b10f71319f34da9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82=C4=99biowski-Owczarek?= Date: Fri, 14 Jun 2024 12:52:21 +0200 Subject: [PATCH 14/15] Only declare element & wrapper once in tests --- tests/unit/dialog/core.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index 945d4f6b2b..4842cdd7cc 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -87,8 +87,10 @@ QUnit.test( "ARIA", function( assert ) { QUnit.test( "aria-modal", function( assert ) { assert.expect( 9 ); - var element = $( "
" ).dialog( { modal: true } ), - wrapper = element.dialog( "widget" ); +var element, wrapper; + + element = $( "
" ).dialog( { modal: true } ); + wrapper = element.dialog( "widget" ); assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); element.dialog( "option", "modal", false ); assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" ); @@ -96,8 +98,8 @@ QUnit.test( "aria-modal", function( assert ) { assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); element.remove(); - var element = $( "
" ).dialog( { modal: false } ), - wrapper = element.dialog( "widget" ); + element = $( "
" ).dialog( { modal: false } ); + wrapper = element.dialog( "widget" ); assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" ); element.dialog( "option", "modal", true ); assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); @@ -105,8 +107,8 @@ QUnit.test( "aria-modal", function( assert ) { assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" ); element.remove(); - var element = $( "
" ).dialog(), - wrapper = element.dialog( "widget" ); + element = $( "
" ).dialog(); + wrapper = element.dialog( "widget" ); assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option not set, aria-modal attribute not added" ); element.dialog( "option", "modal", true ); assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" ); From 2b40401543e817bccb070122b0386dc5c908a58c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82=C4=99biowski-Owczarek?= Date: Fri, 14 Jun 2024 12:54:23 +0200 Subject: [PATCH 15/15] Fix indentation --- tests/unit/dialog/core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/dialog/core.js b/tests/unit/dialog/core.js index 4842cdd7cc..c6bdec778c 100644 --- a/tests/unit/dialog/core.js +++ b/tests/unit/dialog/core.js @@ -87,7 +87,7 @@ QUnit.test( "ARIA", function( assert ) { QUnit.test( "aria-modal", function( assert ) { assert.expect( 9 ); -var element, wrapper; + var element, wrapper; element = $( "
" ).dialog( { modal: true } ); wrapper = element.dialog( "widget" );