Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The JavaScript Style Guide incorrectly says all projects use JSHint #141

Open
mgol opened this issue Jul 26, 2016 · 3 comments
Open

The JavaScript Style Guide incorrectly says all projects use JSHint #141

mgol opened this issue Jul 26, 2016 · 3 comments

Comments

@mgol
Copy link
Member

mgol commented Jul 26, 2016

The JavaScript Style Guide incorrectly says:

Every jQuery project has a Grunt task for linting all JavaScript files: grunt jshint

and then describes the JSHint config. jQuery Core uses ESLint for linting and doesn't have .jshintrc or the jshint Grunt task.

@JuanMaRuiz
Copy link

JuanMaRuiz commented Jan 16, 2019

Hi, I would like to help with this issue. How can I help with it? Where can I find the documentation about eslint configuration? All the links in this page are broken

Best regards.

@dmethvin
Copy link
Member

@JuanMaRuiz at the point this documentation was written, we envisioned that all the projects would share a common setup as far as specific tools and style. However, as we've grown it seems less like a good idea.

I think it might be better to have a general statement here that says something to the effect of, "We recommend that each project create code a code style that the team agrees represents best practice, and enforce those practices with tools like ESLint and Prettier. However, each project is free to use their tools of choice to accomplish this." I suspect this could replace nearly the whole page. What does everyone else think about doing that?

@kswedberg
Copy link
Member

@dmethvin that sounds reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants