Bug in onSymlink

[znewsham]

There is a bug when copying a directory containing a symlink onto itself (e.g., if you were making an rsync type utility):

If options.dereference is not set, then resolvedSrc and resolvedDest will always be equal - since they are the value of the symlink.

        if (stat.isSrcSubdir(resolvedSrc, resolvedDest)) {
          return cb(new Error(`Cannot copy '${resolvedSrc}' to a subdirectory of itself, '${resolvedDest}'.`))
        }

this code needs to be changed to

if (options.dereference && stat.isSrcSubdir(resolvedSrc, resolvedDest)) {

Probably a similar change is required here:

if (destStat.isDirectory() && stat.isSrcSubdir(resolvedDest, resolvedSrc)) {

[RyanZim]

Confirmed bug; but we need something more complicated than your proposed fix. We can't simply ignore these checks when we're not dereferencing; just one example case:

node-fs-extra/lib/copy/__tests__/copy-prevent-copying-into-itself.test.js

Line 351 in a277cbb

it('should error when resolved dest path is a subdir of resolved src path', done => {