Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsiveness: Make more mobile friendly. #1

Open
jportella93 opened this issue Oct 9, 2018 · 5 comments
Open

Responsiveness: Make more mobile friendly. #1

jportella93 opened this issue Oct 9, 2018 · 5 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@jportella93
Copy link
Owner

Now, when a picture is tapped, a modal opens showing the picture.

In order to go back to the gallery you have to tap out of the modal, but depending on the device, this can be hard.

Also images are not centered in some devices.
@jportella93 jportella93 added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 9, 2018
@barrettluke
Copy link

Is this still an issue? If so I would like to work on it.

@jportella93
Copy link
Owner Author

Sure! It is still an issue

@maafaishal
Copy link

I have fixed this issue. Please take a look my PR#4

@barrettluke
Copy link

Did PR#4 fix the responsiveness ?

@maafaishal
Copy link

Yup. You can check my PR#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maafaishal @barrettluke @jportella93