Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain cell failures are not detected #190

Open
ceball opened this issue Jun 16, 2020 · 0 comments
Open

Certain cell failures are not detected #190

ceball opened this issue Jun 16, 2020 · 0 comments
Labels
part: cell tests Relating to cell testing component type: bug Concrete, reproducible bugs

Comments

@ceball
Copy link
Collaborator

ceball commented Jun 16, 2020

Inherited from nbval. E.g. test for bad magics is currently marked "known fail":

# TODO: see https://github.com/computationalmodelling/nbval/issues/147
class TestSomeSanity(_TestCellTests):
NBNAME = BROKEN_MAGICS
@pytest.mark.xfail(reason="error messages on shell channel are ignored by nbval")
def test_bad_magic_does_let_everything_pass(self):

(note: typo in above method name - "does not")

There might be other cases too, haven't investigated.

@ceball ceball added bug part: cell tests Relating to cell testing component labels Jun 16, 2020
@timkpaine timkpaine added type: bug Concrete, reproducible bugs and removed bug labels Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: cell tests Relating to cell testing component type: bug Concrete, reproducible bugs
Projects
None yet
Development

No branches or pull requests

2 participants