Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to SearchIndexPlugin #639

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joshwooding
Copy link
Contributor

@joshwooding joshwooding commented Aug 29, 2024

Not sure what the correct API should be

@joshwooding joshwooding requested a review from a team as a code owner August 29, 2024 22:09
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mosaic ❌ Failed (Inspect) Sep 9, 2024 11:16am

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 7a73533

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@jpmorganchase/mosaic-plugins Minor
@jpmorganchase/mosaic-cli Minor
@jpmorganchase/mosaic-labs-components Minor
@jpmorganchase/mosaic-components Minor
@jpmorganchase/mosaic-content-editor-plugin Minor
@jpmorganchase/mosaic-core Minor
@jpmorganchase/mosaic-create-site Minor
@jpmorganchase/mosaic-from-http-request Minor
@jpmorganchase/mosaic-layouts Minor
@jpmorganchase/mosaic-open-api-component Minor
@jpmorganchase/mosaic-schemas Minor
@jpmorganchase/mosaic-serialisers Minor
@jpmorganchase/mosaic-site-components Minor
@jpmorganchase/mosaic-site-middleware Minor
@jpmorganchase/mosaic-site-preset-styles Minor
@jpmorganchase/mosaic-site Minor
@jpmorganchase/mosaic-sitemap-component Minor
@jpmorganchase/mosaic-source-figma Minor
@jpmorganchase/mosaic-source-git-repo Minor
@jpmorganchase/mosaic-source-http Minor
@jpmorganchase/mosaic-source-local-folder Minor
@jpmorganchase/mosaic-source-readme Minor
@jpmorganchase/mosaic-source-storybook Minor
@jpmorganchase/mosaic-standard-generator Minor
@jpmorganchase/mosaic-store Minor
@jpmorganchase/mosaic-theme Minor
@jpmorganchase/mosaic-types Minor
@jpmorganchase/mosaic-workflows Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DavieReid
Copy link
Contributor

What pages are you trying to exclude? Can they be hidden pages with a . in the filename?

@joshwooding
Copy link
Contributor Author

What pages are you trying to exclude? Can they be hidden pages with a . in the filename?

In Salt, we want to not index example pages but we want them to show on the site. Not sure if . will help there?

This might be quite custom though, so maybe we'll need a custom Search plugin anyway, if so it can live there for now

'@jpmorganchase/mosaic-plugins': minor
---

Add a `filter` option to SearchIndexPlugin, which allows you to exclude pages from the search index.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the plugin already has include in its naming convention, should we call this excludePages (or similar) rather than filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants