-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter to SearchIndexPlugin #639
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7a73533 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
What pages are you trying to exclude? Can they be hidden pages with a |
In Salt, we want to not index example pages but we want them to show on the site. Not sure if This might be quite custom though, so maybe we'll need a custom Search plugin anyway, if so it can live there for now |
'@jpmorganchase/mosaic-plugins': minor | ||
--- | ||
|
||
Add a `filter` option to SearchIndexPlugin, which allows you to exclude pages from the search index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the plugin already has include in its naming convention, should we call this excludePages (or similar) rather than filter
Not sure what the correct API should be