Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crawl nested licenses [add option to not use gitignore] #56

Open
4rokis opened this issue Jun 13, 2020 · 7 comments
Open

Crawl nested licenses [add option to not use gitignore] #56

4rokis opened this issue Jun 13, 2020 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@4rokis
Copy link

4rokis commented Jun 13, 2020

Command
askalono crawl {directory}

Checks the directory and if the directory has license file it exits with the results.

Folder structure

  • root
    • folder1
      • LICENSE1
      • folder3
        • LICENSE2
    • folder2
      • LICENSE3

Call
askalono crawl ./root

Returns:

{LICENSE1 analysis}
{LICENSE3 analysis}

However I need for it to return all of the license files

{LICENSE1 analysis}
{LICENSE2 analysis}
{LICENSE3 analysis}

Is that somehow possible?

😭 I cannot read RUST 😓

@4rokis 4rokis changed the title Crawl all licenses Crawl nested licenses Jun 13, 2020
@jpeddicord
Copy link
Owner

Hi! It should definitely be crawling through all directory levels. Is there a specific file path (with file name) that it's missing? By default, crawl will only look at files that it thinks are licenses (from the name). If you'd like to have it attempt to identify everything, you can try this:

askalono crawl --glob='*' ./root

@4rokis
Copy link
Author

4rokis commented Jun 15, 2020

Hmm, you are correct, i have overlooked that. It seems that it is just ignoring node_modules folder. Is there some specific reason for that?

@4rokis
Copy link
Author

4rokis commented Jun 15, 2020

My usage is that i want to go thought all of your dependencies of the project and check the licenses you are using. Therefore i need for it to go thought node_modules. It is fine if run it on root/node_modules. However some modules have nested node_modules and they got ignored

@jpeddicord
Copy link
Owner

Ah! Do you have node_modules in your .gitignore?

@4rokis
Copy link
Author

4rokis commented Jun 15, 2020

For sure it is there.... 🤦 Why i haven't thought about it

@jpeddicord
Copy link
Owner

That's probably it. I'll keep this issue open to add a flag to askalono to not use gitignore, since I could see wanting to both ignore and crawl it.

@jpeddicord jpeddicord changed the title Crawl nested licenses Crawl nested licenses [add option to not use gitignore] Jun 15, 2020
@4rokis
Copy link
Author

4rokis commented Jun 15, 2020

It works. Thanks very much for the support

@jpeddicord jpeddicord added enhancement New feature or request good first issue Good for newcomers labels Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants