Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vkvg reproducible #59

Closed
Rubo3 opened this issue Jan 22, 2022 · 1 comment
Closed

Make vkvg reproducible #59

Rubo3 opened this issue Jan 22, 2022 · 1 comment

Comments

@Rubo3
Copy link
Contributor

Rubo3 commented Jan 22, 2022

This part of the message I posted on the issue #57 made me wonder:

Fatal : VkResult is -2 in /run/media/Volume/Marco/Nextcloud/Sviluppo/aur-vkvg/src/vkvg-0.2.1/vkh/src/vkh_image.c at line 57
Segmentation fault (core dumped)

The path of my build directory ended up in the binaries, that's why makepkg tells:

==> WARNING: Package contains reference to $srcdir
usr/lib/libvkh.so.0.1.0
usr/lib/libvkvg.so.0.2

So it seems the issue is here https://github.com/jpbruyere/vkhelpers/blob/41daf55f834aede1698aaa1afae02e2faf22530a/src/vkh_image.c#L57 with VK_CHECK_RESULT. Looking for some CMAKE variables, I found this https://cmake.org/cmake/help/latest/prop_tgt/BUILD_RPATH_USE_ORIGIN.html but even after raising the minimum CMake version to 3.14 and adding SET(BUILD_RPATH_USE_ORIGIN TRUE) I still get the warning.
How can we make this library reproducible?

@Rubo3
Copy link
Contributor Author

Rubo3 commented Jan 22, 2022

It sufficed to substitute the source directory path with an empty string with sed. I pushed an updated PKGBUILD on the AUR.

@Rubo3 Rubo3 closed this as completed Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant