Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangle Fan topology not supported on macOS #49

Open
jpbruyere opened this issue Jun 7, 2021 · 1 comment
Open

Triangle Fan topology not supported on macOS #49

jpbruyere opened this issue Jun 7, 2021 · 1 comment

Comments

@jpbruyere
Copy link
Owner

jpbruyere commented Jun 7, 2021

Triangle fans are used to fill polygons with the Even/Odd technic, it's not supported by moltenVK.
A quick fix has be apply to disable Even/Odd on macOS.

The workaround is to bind the IBO in the _poly_fill() method and produce triangle list indices as the fan would output with the contour.

@fzwoch
Copy link
Contributor

fzwoch commented Jun 29, 2021

Just for the record, according to https://www.khronos.org/registry/vulkan/specs/1.0-extensions/html/chap21.html#drawing-primitive-topologies I understand it as that TRIANGLE_FAN is not part of the core and any implementation is free to not support it. With moltenVK probably being the most prominent.

VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN specifies a series of connected triangle primitives with all triangles sharing a common vertex. If the VK_KHR_portability_subset extension is enabled, and VkPhysicalDevicePortabilitySubsetFeaturesKHR::triangleFans is VK_FALSE, then triangle fans are not supported by the implementation, and VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN must not be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants