Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: does interrupt work for you? #406

Open
ghost opened this issue Nov 4, 2013 · 2 comments
Open

question: does interrupt work for you? #406

ghost opened this issue Nov 4, 2013 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 4, 2013

Hi guys,

I noticed that my DK rotation didn't interrupted today on Galakras HC adds. Do it work for you with other characters/specs?

@htordeux
Copy link
Contributor

htordeux commented Nov 4, 2013

look at the function jps.shouldKick(unit) in jpccinterrupt and check if your version contains
if not jps.canDPS(unit) then return false end
if not jps.Interrupts then return false end

so if jps.Interrupts is false you've not shouldkick

@ghost
Copy link
Author

ghost commented Nov 4, 2013

problem with canDPS is that there are some raid mobs you need to interrupt even if they are neutral too you. (UnitIsEnemy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant