Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical UI for Rotation Design #370

Open
kirk24788 opened this issue Jul 25, 2013 · 1 comment
Open

Graphical UI for Rotation Design #370

kirk24788 opened this issue Jul 25, 2013 · 1 comment

Comments

@kirk24788
Copy link
Contributor

Brought up by spammatuamamma in #369:

is there a way to write a new rotation in a slightly less 'geeky' way, for those of us who think command line is something happening in the military?

Oh, nothing to do with that... I was just wondering if one was unable to do anything without a graphic ui, is there any way to kind of be inspired by Noxxic/icy-veins and just work your rotations (even those who are obsolete) intuitively...

@kirk24788
Copy link
Contributor Author

Now...to give you a first replay...

First - the rotation are actually really basic, glued together with some "magic" code

jps.registerStaticTable("WARRIOR","FURY", {
   {"Colossus Smash", "jps.rage() > 100", "target"},
   {"Heroic Strike", "jps.rage() > 20", "target"},
   ...
}, "My Fury Rotation")

The first and the last contain the "magic" code...Telling JPS to create a new Rotation for a Fury Warrior which is named "My Fury Rotation".
Between this code there's a list of Spells to be casted containing SPELL, CONDITION WHEN TO CAST, TARGET.

It's not too much....and trust me - this is WAY faster than a graphical UI. Even though a GUI might work for this rotation a lot of the rotations are way more dedicated - and you just can't make a GUI which could handle that.

So a GUI would only help to create basic rotations which might not be optimal - which shouldn't be the goal.

And I'm only talking about a GUID which is not InGame....if you want to edit a complete Rotation ingame...that would be a big task, needed some major rework of the JPS code without much benefit - since those rotation wouldn't be optimal.

On the other hand - this is open source - if you find someone willing to do this...why not.

But I would suggest to concentrate energies on the existing rotations and updating/documenting them.
And evne if you don't know how to write a rotation....creating new tickets with the rotations which are out of date or are missing stuff is also a great help. I'm only focussing on the warlock rotations and doing the other rotations only I need to play any of those classes (and I'm not even having a lvl 90 warrior or monk..).
I guess same goes for most of those people currently commiting to JPS.

PS:
While it won't help you much if you're not a warlock, I'm currently working on a Warlock Rotation with a limited GUI - it won't let you change the rotation, but some parameters which come with it. But I guess I won't have it finished before I'm going on vacation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant