Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showNavigationOnTouchDevice is not part of the type for CarouselProps #381

Open
BrendanHart opened this issue Jun 3, 2020 · 2 comments
Open

Comments

@BrendanHart
Copy link
Contributor

BrendanHart commented Jun 3, 2020

Steps to reproduce the behavior:
Attempt to set the value for showNavigationOnTouchDevice in a TypeScript file, which is stated to exist in https://jossmac.github.io/react-images

Expected behavior:
The file compiles and the value can be set.

Actual behavior:
The file fails to compile:

  Property 'showNavigationOnTouchDevice' does not exist on type 'IntrinsicAttributes & CarouselProps & { children?: ReactNode; }'.
@ardalann
Copy link

showNavigationOnTouchDevice doesn't do anything for me even when I ignore the Typescript error (using @ts-ignore). Does it work for you?

@BrendanHart
Copy link
Contributor Author

@ardalann - I didn't notice a difference when I tried it either, but didn't investigate deeply enough to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants